diff options
| author | Tom Tromey <tom@tromey.com> | 2019-07-13 16:47:31 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-08-20 16:45:50 -0600 |
| commit | ab0e1f1a4507f91536b583c57a492cb9d3aaf6f2 (patch) | |
| tree | cea4886a288944d3af598bb3fc9d26af76dbd3ec /gdb/tui/tui-regs.c | |
| parent | 100c2bf31fa9bde80d997a5b39d1a07e0505a1cb (diff) | |
| download | gdb-ab0e1f1a4507f91536b583c57a492cb9d3aaf6f2.zip gdb-ab0e1f1a4507f91536b583c57a492cb9d3aaf6f2.tar.gz gdb-ab0e1f1a4507f91536b583c57a492cb9d3aaf6f2.tar.bz2 | |
Change tui_make_window to be a method
I combined several small changes into one patch here. I believe I
started by noticing that the "title" is not needed by tui_gen_win_info
and could be self-managing (i.e. std::string). Moving this revealed
that "can_box" is also a property of tui_win_info and not
tui_gen_win_info; and this in turn caused the changes to
tui_make_window and box_win.
2019-08-20 Tom Tromey <tom@tromey.com>
* tui/tui-wingeneral.h (tui_make_window): Don't declare.
* tui/tui-wingeneral.c (box_win): Change type of win_info.
(box_win): Update.
(tui_gen_win_info::make_window): Rename from tui_make_window.
(tui_win_info::make_window): New method.
(tui_gen_win_info::make_visible): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-regs.c (tui_data_window::show_register_group): Update.
(tui_data_window::display_registers_from): Update.
* tui/tui-layout.c (tui_gen_win_info::resize): Update.
* tui/tui-data.h (struct tui_gen_win_info) <make_window>:
Declare.
<can_box>: Remove.
<title>: Remove.
(struct tui_win_info) <make_window>: Declare.
<can_box>: Now virtual.
<title>: New member.
* tui/tui-data.c (~tui_gen_win_info): Don't free title.
* tui/tui-command.c (tui_cmd_window::resize): Update.
Diffstat (limited to 'gdb/tui/tui-regs.c')
| -rw-r--r-- | gdb/tui/tui-regs.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index f468940..71037d4 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -185,8 +185,7 @@ tui_data_window::show_register_group (struct reggroup *group, int regnum, pos; /* Make a new title showing which group we display. */ - xfree (title); - title = xstrprintf ("Register group: %s", reggroup_name (group)); + title = string_printf ("Register group: %s", reggroup_name (group)); /* See how many registers must be displayed. */ nr_regs = 0; @@ -302,7 +301,7 @@ tui_data_window::display_registers_from (int start_element_no) data_item_win->width = item_win_width; data_item_win->origin.x = (item_win_width * j) + 1; data_item_win->origin.y = cur_y; - tui_make_window (data_item_win); + data_item_win->make_visible (true); scrollok (data_item_win->handle, FALSE); } touchwin (data_item_win->handle); |