diff options
| author | Luis Machado <luis.machado@linaro.org> | 2021-01-15 13:16:04 -0300 |
|---|---|---|
| committer | Luis Machado <luis.machado@linaro.org> | 2021-01-19 14:42:23 -0300 |
| commit | bdec2917b1e94c7198ba39919f45060067952f43 (patch) | |
| tree | 808f5e6ba99e684a6c2328e25f338dc0731970e1 /gdb/tramp-frame.c | |
| parent | c65ca138c4be913964dbd332c44e861fced991cd (diff) | |
| download | gdb-bdec2917b1e94c7198ba39919f45060067952f43.zip gdb-bdec2917b1e94c7198ba39919f45060067952f43.tar.gz gdb-bdec2917b1e94c7198ba39919f45060067952f43.tar.bz2 | |
Convert some frame functions to use gdb::array_view.
This patch converts the most obvious functions from gdb/frame.h to use
the gdb::array_view abstraction. I've converted the ones that used buffer +
length.
There are others using only the buffer, with an implicit size. I did not
touch those for now. But it would be nice to pass the size for safety.
Tested with --enable-targets=all on Ubuntu 18.04/20.04 aarch64-linux.
gdb/ChangeLog
2021-01-19 Luis Machado <luis.machado@linaro.org>
* frame.h (get_frame_register_bytes): Pass a gdb::array_view instead
of buffer + length.
(put_frame_register_bytes): Likewise.
Adjust documentation.
(get_frame_memory): Pass a gdb::array_view instead of buffer + length.
(safe_frame_unwind_memory): Likewise.
* frame.c (get_frame_register_bytes, put_frame_register_bytes)
(get_frame_memory, safe_frame_unwind_memory): Adjust to use
gdb::array_view.
* amd64-fbsd-tdep.c (amd64fbsd_sigtramp_p): Likewise.
* amd64-linux-tdep.c (amd64_linux_sigtramp_start): Likewise.
* amd64-obsd-tdep.c (amd64obsd_sigtramp_p): Likewise.
* arc-linux-tdep.c (arc_linux_is_sigtramp): Likewise.
* cris-tdep.c (cris_sigtramp_start, cris_rt_sigtramp_start): Likewise.
* dwarf2/loc.c (rw_pieced_value): Likewise.
* hppa-tdep.c (hppa_frame_cache): Likewise.
* i386-fbsd-tdep.c (i386fbsd_sigtramp_p): Likewise.
* i386-gnu-tdep.c (i386_gnu_sigtramp_start): Likewise.
* i386-linux-tdep.c (i386_linux_sigtramp_start)
(i386_linux_rt_sigtramp_start): Likewise.
* i386-obsd-tdep.c (i386obsd_sigtramp_p): Likewise.
* i386-tdep.c (i386_register_to_value): Likewise.
* i387-tdep.c (i387_register_to_value): Likewise.
* ia64-tdep.c (ia64_register_to_value): Likewise.
* m32r-linux-tdep.c (m32r_linux_sigtramp_start)
(m32r_linux_rt_sigtramp_start): Likewise.
* m68k-linux-tdep.c (m68k_linux_pc_in_sigtramp): Likewise.
* m68k-tdep.c (m68k_register_to_value): Likewise.
* mips-tdep.c (mips_register_to_value)
(mips_value_to_register): Likewise.
* ppc-fbsd-tdep.c (ppcfbsd_sigtramp_frame_sniffer)
(ppcfbsd_sigtramp_frame_cache): Likewise.
* ppc-obsd-tdep.c (ppcobsd_sigtramp_frame_sniffer)
(ppcobsd_sigtramp_frame_cache): Likewise.
* rs6000-tdep.c (rs6000_in_function_epilogue_frame_p)
(rs6000_register_to_value): Likewise.
* tilegx-tdep.c (tilegx_analyze_prologue): Likewise.
* tramp-frame.c (tramp_frame_start): Likewise.
* valops.c (value_assign): Likewise.
Diffstat (limited to 'gdb/tramp-frame.c')
| -rw-r--r-- | gdb/tramp-frame.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/gdb/tramp-frame.c b/gdb/tramp-frame.c index 5f5d1b4..b13ca51 100644 --- a/gdb/tramp-frame.c +++ b/gdb/tramp-frame.c @@ -102,14 +102,15 @@ tramp_frame_start (const struct tramp_frame *tramp, { gdb_byte buf[sizeof (tramp->insn[0])]; ULONGEST insn; + size_t insn_size = tramp->insn_size; if (tramp->insn[i].bytes == TRAMP_SENTINEL_INSN) return func; if (!safe_frame_unwind_memory (this_frame, - func + i * tramp->insn_size, - buf, tramp->insn_size)) + func + i * insn_size, + {buf, insn_size})) break; - insn = extract_unsigned_integer (buf, tramp->insn_size, byte_order); + insn = extract_unsigned_integer (buf, insn_size, byte_order); if (tramp->insn[i].bytes != (insn & tramp->insn[i].mask)) break; } |