diff options
author | Michael Snyder <msnyder@vmware.com> | 2011-01-11 21:53:25 +0000 |
---|---|---|
committer | Michael Snyder <msnyder@vmware.com> | 2011-01-11 21:53:25 +0000 |
commit | c378eb4eaae2baecb17b41ba928daf9dc74b1aab (patch) | |
tree | 0b086b28cdcda59cb9004a848297fb08d804ed20 /gdb/tracepoint.c | |
parent | 6c162d5eb67081ad91106259239a9a1ef00ec7a6 (diff) | |
download | gdb-c378eb4eaae2baecb17b41ba928daf9dc74b1aab.zip gdb-c378eb4eaae2baecb17b41ba928daf9dc74b1aab.tar.gz gdb-c378eb4eaae2baecb17b41ba928daf9dc74b1aab.tar.bz2 |
2011-01-11 Michael Snyder <msnyder@vmware.com>
* s390-tdep.c: Comment cleanup, mostly periods and spaces.
* score-tdep.c: Ditto.
* score-tdep.h: Ditto.
* ser-base.c: Ditto.
* ser-go32.c: Ditto.
* serial.c: Ditto.
* serial.h: Ditto.
* ser-mingw.c: Ditto.
* ser-pipe.c: Ditto.
* ser-tcp.c: Ditto.
* ser-unix.c: Ditto.
* sh64-tdep.c: Ditto.
* shnbsd-nat.c: Ditto.
* sh-tdep.c: Ditto.
* sh-tdep.h: Ditto.
* solib.c: Ditto.
* solib-darwin.c: Ditto.
* solib-frv.c: Ditto.
* solib.h: Ditto.
* solib-irix.c: Ditto.
* solib-osf.c: Ditto.
* solib-pa64.c: Ditto.
* solib-som.c: Ditto.
* solib-spu.c: Ditto.
* solib-sunos.c: Ditto.
* solib-svr4.c: Ditto.
* solist.h: Ditto.
* sol-thread.c: Ditto.
* somread.c: Ditto.
* source.c: Ditto.
* source.h: Ditto.
* sparc64-linux-tdep.c: Ditto.
* sparc64-tdep.c: Ditto.
* sparc-linux-nat.c: Ditto.
* sparc-linux-tdep.c: Ditto.
* sparc-sol2-nat.c: Ditto.
* sparc-sol2-tdep.c: Ditto.
* sparc-tdep.c: Ditto.
* sparc-tdep.h: Ditto.
* spu-tdep.c: Ditto.
* stabsread.c: Ditto.
* stabsread.h: Ditto.
* stack.c: Ditto.
* symfile.c: Ditto.
* symfile.h: Ditto.
* symmisc.c: Ditto.
* symtab.c: Ditto.
* symtab.h: Ditto.
* target.c: Ditto.
* target-descriptions.c: Ditto.
* target-descriptions.h: Ditto.
* target.h: Ditto.
* target-memory.c: Ditto.
* terminal.h: Ditto.
* thread.c: Ditto.
* top.c: Ditto.
* tracepoint.c: Ditto.
* tracepoint.h: Ditto.
* trad-frame.h: Ditto.
* typeprint.c: Ditto.
Diffstat (limited to 'gdb/tracepoint.c')
-rw-r--r-- | gdb/tracepoint.c | 140 |
1 files changed, 70 insertions, 70 deletions
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index e21fec3..dcae841 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -142,13 +142,13 @@ static int traceframe_number; /* Tracepoint for last traceframe collected. */ static int tracepoint_number; -/* Symbol for function for last traceframe collected */ +/* Symbol for function for last traceframe collected. */ static struct symbol *traceframe_fun; -/* Symtab and line for last traceframe collected */ +/* Symtab and line for last traceframe collected. */ static struct symtab_and_line traceframe_sal; -/* Tracing command lists */ +/* Tracing command lists. */ static struct cmd_list_element *tfindlist; /* List of expressions to collect by default at each tracepoint hit. */ @@ -225,7 +225,7 @@ set_tracepoint_num (int num) } /* Set externally visible debug variables for querying/printing - the traceframe context (line, function, file) */ + the traceframe context (line, function, file). */ static void set_traceframe_context (struct frame_info *trace_frame) @@ -597,7 +597,7 @@ validate_actionline (char **line, struct breakpoint *t) struct bp_location *loc; struct agent_expr *aexpr; - /* if EOF is typed, *line is NULL */ + /* If EOF is typed, *line is NULL. */ if (*line == NULL) return; @@ -618,12 +618,12 @@ validate_actionline (char **line, struct breakpoint *t) if (cmd_cfunc_eq (c, collect_pseudocommand)) { do - { /* repeat over a comma-separated list */ - QUIT; /* allow user to bail out with ^C */ + { /* Repeat over a comma-separated list. */ + QUIT; /* Allow user to bail out with ^C. */ while (isspace ((int) *p)) p++; - if (*p == '$') /* look for special pseudo-symbols */ + if (*p == '$') /* Look for special pseudo-symbols. */ { if (0 == strncasecmp ("reg", p + 1, 3) || 0 == strncasecmp ("arg", p + 1, 3) @@ -682,8 +682,8 @@ validate_actionline (char **line, struct breakpoint *t) else if (cmd_cfunc_eq (c, teval_pseudocommand)) { do - { /* repeat over a comma-separated list */ - QUIT; /* allow user to bail out with ^C */ + { /* Repeat over a comma-separated list. */ + QUIT; /* Allow user to bail out with ^C. */ while (isspace ((int) *p)) p++; @@ -715,7 +715,7 @@ validate_actionline (char **line, struct breakpoint *t) else if (cmd_cfunc_eq (c, while_stepping_pseudocommand)) { - char *steparg; /* in case warning is necessary */ + char *steparg; /* In case warning is necessary. */ while (isspace ((int) *p)) p++; @@ -739,7 +739,7 @@ enum { struct memrange { int type; /* memrange_absolute for absolute memory range, - else basereg number */ + else basereg number. */ bfd_signed_vma start; bfd_signed_vma end; }; @@ -764,7 +764,7 @@ tracepoint_list, stepping_list; static int memrange_cmp (const void *, const void *); -/* compare memranges for qsort */ +/* Compare memranges for qsort. */ static int memrange_cmp (const void *va, const void *vb) { @@ -833,7 +833,7 @@ add_register (struct collection_list *collection, unsigned int regno) collection->regs_mask[regno / 8] |= 1 << (regno % 8); } -/* Add a memrange to a collection list */ +/* Add a memrange to a collection list. */ static void add_memrange (struct collection_list *memranges, int type, bfd_signed_vma base, @@ -1002,20 +1002,20 @@ collect_symbol (struct collection_list *collect, discard_cleanups (old_chain1); add_aexpr (collect, aexpr); - /* take care of the registers */ + /* Take care of the registers. */ if (aexpr->reg_mask_len > 0) { int ndx1, ndx2; for (ndx1 = 0; ndx1 < aexpr->reg_mask_len; ndx1++) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ if (aexpr->reg_mask[ndx1] != 0) { - /* assume chars have 8 bits */ + /* Assume chars have 8 bits. */ for (ndx2 = 0; ndx2 < 8; ndx2++) if (aexpr->reg_mask[ndx1] & (1 << ndx2)) - /* it's used -- record it */ + /* It's used -- record it. */ add_register (collect, ndx1 * 8 + ndx2); } } @@ -1036,7 +1036,7 @@ struct add_local_symbols_data int count; }; -/* The callback for the locals and args iterators */ +/* The callback for the locals and args iterators. */ static void do_collect_symbol (const char *print_name, @@ -1050,7 +1050,7 @@ do_collect_symbol (const char *print_name, p->count++; } -/* Add all locals (or args) symbols to collection list */ +/* Add all locals (or args) symbols to collection list. */ static void add_local_symbols (struct collection_list *collect, struct gdbarch *gdbarch, CORE_ADDR pc, @@ -1121,7 +1121,7 @@ clear_collection_list (struct collection_list *list) list->strace_data = 0; } -/* reduce a collection list to string form (for gdb protocol) */ +/* Reduce a collection list to string form (for gdb protocol). */ static char ** stringify_collection_list (struct collection_list *list, char *string) { @@ -1147,9 +1147,9 @@ stringify_collection_list (struct collection_list *list, char *string) } for (i = sizeof (list->regs_mask) - 1; i > 0; i--) - if (list->regs_mask[i] != 0) /* skip leading zeroes in regs_mask */ + if (list->regs_mask[i] != 0) /* Skip leading zeroes in regs_mask. */ break; - if (list->regs_mask[i] != 0) /* prepare to send regs_mask to the stub */ + if (list->regs_mask[i] != 0) /* Prepare to send regs_mask to the stub. */ { if (info_verbose) printf_filtered ("\nCollecting registers (mask): 0x"); @@ -1157,7 +1157,7 @@ stringify_collection_list (struct collection_list *list, char *string) *end++ = 'R'; for (; i >= 0; i--) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ if (info_verbose) printf_filtered ("%02X", list->regs_mask[i]); sprintf (end, "%02X", list->regs_mask[i]); @@ -1172,7 +1172,7 @@ stringify_collection_list (struct collection_list *list, char *string) printf_filtered ("Collecting memranges: \n"); for (i = 0, count = 0, end = temp_buf; i < list->next_memrange; i++) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ sprintf_vma (tmp2, list->list[i].start); if (info_verbose) { @@ -1208,7 +1208,7 @@ stringify_collection_list (struct collection_list *list, char *string) for (i = 0; i < list->next_aexpr_elt; i++) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ if ((count + 10 + 2 * list->aexpr_list[i]->len) > MAX_AGENT_EXPR_LEN) { (*str_list)[ndx] = savestring (temp_buf, count); @@ -1262,7 +1262,7 @@ encode_actions_1 (struct command_line *action, for (; action; action = action->next) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ action_exp = action->line; while (isspace ((int) *action_exp)) action_exp++; @@ -1274,8 +1274,8 @@ encode_actions_1 (struct command_line *action, if (cmd_cfunc_eq (cmd, collect_pseudocommand)) { do - { /* repeat over a comma-separated list */ - QUIT; /* allow user to bail out with ^C */ + { /* Repeat over a comma-separated list. */ + QUIT; /* Allow user to bail out with ^C. */ while (isspace ((int) *action_exp)) action_exp++; @@ -1339,7 +1339,7 @@ encode_actions_1 (struct command_line *action, } case UNOP_MEMVAL: - /* safe because we know it's a simple expression */ + /* Safe because we know it's a simple expression. */ tempval = evaluate_expression (exp); addr = value_address (tempval); len = TYPE_LENGTH (check_typedef (exp->elts[1].type)); @@ -1355,7 +1355,7 @@ encode_actions_1 (struct command_line *action, tloc->address); break; - default: /* full-fledged expression */ + default: /* Full-fledged expression. */ aexpr = gen_trace_for_expr (tloc->address, exp); old_chain1 = make_cleanup_free_agent_expr (aexpr); @@ -1367,7 +1367,7 @@ encode_actions_1 (struct command_line *action, discard_cleanups (old_chain1); add_aexpr (collect, aexpr); - /* take care of the registers */ + /* Take care of the registers. */ if (aexpr->reg_mask_len > 0) { int ndx1; @@ -1375,13 +1375,13 @@ encode_actions_1 (struct command_line *action, for (ndx1 = 0; ndx1 < aexpr->reg_mask_len; ndx1++) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ if (aexpr->reg_mask[ndx1] != 0) { - /* assume chars have 8 bits */ + /* Assume chars have 8 bits. */ for (ndx2 = 0; ndx2 < 8; ndx2++) if (aexpr->reg_mask[ndx1] & (1 << ndx2)) - /* it's used -- record it */ + /* It's used -- record it. */ add_register (collect, ndx1 * 8 + ndx2); } @@ -1397,8 +1397,8 @@ encode_actions_1 (struct command_line *action, else if (cmd_cfunc_eq (cmd, teval_pseudocommand)) { do - { /* repeat over a comma-separated list */ - QUIT; /* allow user to bail out with ^C */ + { /* Repeat over a comma-separated list. */ + QUIT; /* Allow user to bail out with ^C. */ while (isspace ((int) *action_exp)) action_exp++; @@ -1528,7 +1528,7 @@ start_tracing (void) tp_vec = all_tracepoints (); - /* No point in tracing without any tracepoints... */ + /* No point in tracing without any tracepoints... */ if (VEC_length (breakpoint_p, tp_vec) == 0) { VEC_free (breakpoint_p, tp_vec); @@ -1635,7 +1635,7 @@ void stop_tracing (void) { target_trace_stop (); - /* should change in response to reply? */ + /* Should change in response to reply? */ current_trace_status ()->running = 0; } @@ -1950,7 +1950,7 @@ tfind_1 (enum trace_find_type type, int num, { if (info_verbose) printf_filtered ("End of trace buffer.\n"); -#if 0 /* dubious now? */ +#if 0 /* dubious now? */ /* The following will not recurse, since it's special-cased. */ trace_find_command ("-1", from_tty); @@ -1992,7 +1992,7 @@ tfind_1 (enum trace_find_type type, int num, ui_out_field_string (uiout, "found", "0"); else if (type == tfind_number && num == -1) printf_unfiltered (_("No longer looking at any trace frame\n")); - else /* this case may never occur, check */ + else /* This case may never occur, check. */ printf_unfiltered (_("No trace frame found\n")); } @@ -2038,7 +2038,7 @@ tfind_1 (enum trace_find_type type, int num, /* tfind command */ static void trace_find_command (char *args, int from_tty) -{ /* this should only be called with a numeric argument */ +{ /* This should only be called with a numeric argument. */ int frameno = -1; if (current_trace_status ()->running && !current_trace_status ()->from_file) @@ -2047,7 +2047,7 @@ trace_find_command (char *args, int from_tty) if (args == 0 || *args == 0) { /* TFIND with no args means find NEXT trace frame. */ if (traceframe_number == -1) - frameno = 0; /* "next" is first one */ + frameno = 0; /* "next" is first one. */ else frameno = traceframe_number + 1; } @@ -2125,7 +2125,7 @@ trace_find_tracepoint_command (char *args, int from_tty) if (tracepoint_number == -1) error (_("No current tracepoint -- please supply an argument.")); else - tdp = tracepoint_number; /* default is current TDP */ + tdp = tracepoint_number; /* Default is current TDP. */ } else tdp = parse_and_eval_long (args); @@ -2231,14 +2231,14 @@ trace_find_range_command (char *args, int from_tty) if (0 != (tmp = strchr (args, ','))) { - *tmp++ = '\0'; /* terminate start address */ + *tmp++ = '\0'; /* Terminate start address. */ while (isspace ((int) *tmp)) tmp++; start = parse_and_eval_address (args); stop = parse_and_eval_address (tmp); } else - { /* no explicit end address? */ + { /* No explicit end address? */ start = parse_and_eval_address (args); stop = start + 1; /* ??? */ } @@ -2257,21 +2257,21 @@ trace_find_outside_command (char *args, int from_tty) error (_("May not look at trace frames while trace is running.")); if (args == 0 || *args == 0) - { /* XXX FIXME: what should default behavior be? */ + { /* XXX FIXME: what should default behavior be? */ printf_filtered ("Usage: tfind outside <startaddr>,<endaddr>\n"); return; } if (0 != (tmp = strchr (args, ','))) { - *tmp++ = '\0'; /* terminate start address */ + *tmp++ = '\0'; /* Terminate start address. */ while (isspace ((int) *tmp)) tmp++; start = parse_and_eval_address (args); stop = parse_and_eval_address (tmp); } else - { /* no explicit end address? */ + { /* No explicit end address? */ start = parse_and_eval_address (args); stop = start + 1; /* ??? */ } @@ -2299,25 +2299,25 @@ scope_info (char *args, int from_tty) sals = decode_line_1 (&args, 1, NULL, 0, &canonical, NULL); if (sals.nelts == 0) - return; /* presumably decode_line_1 has already warned */ + return; /* Presumably decode_line_1 has already warned. */ - /* Resolve line numbers to PC */ + /* Resolve line numbers to PC. */ resolve_sal_pc (&sals.sals[0]); block = block_for_pc (sals.sals[0].pc); while (block != 0) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ ALL_BLOCK_SYMBOLS (block, iter, sym) { - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ if (count == 0) printf_filtered ("Scope for %s:\n", save_args); count++; symname = SYMBOL_PRINT_NAME (sym); if (symname == NULL || *symname == '\0') - continue; /* probably botched, certainly useless */ + continue; /* Probably botched, certainly useless. */ gdbarch = get_objfile_arch (SYMBOL_SYMTAB (sym)->objfile); @@ -2325,10 +2325,10 @@ scope_info (char *args, int from_tty) switch (SYMBOL_CLASS (sym)) { default: - case LOC_UNDEF: /* messed up symbol? */ + case LOC_UNDEF: /* Messed up symbol? */ printf_filtered ("a bogus symbol, class %d.\n", SYMBOL_CLASS (sym)); - count--; /* don't count this one */ + count--; /* Don't count this one. */ continue; case LOC_CONST: printf_filtered ("a constant with value %ld (0x%lx)", @@ -2457,7 +2457,7 @@ trace_dump_actions (struct command_line *action, { struct cmd_list_element *cmd; - QUIT; /* allow user to bail out with ^C */ + QUIT; /* Allow user to bail out with ^C. */ action_exp = action->line; while (isspace ((int) *action_exp)) action_exp++; @@ -2491,8 +2491,8 @@ trace_dump_actions (struct command_line *action, if (stepping_frame == stepping_actions) { do - { /* repeat over a comma-separated list */ - QUIT; /* allow user to bail out with ^C */ + { /* Repeat over a comma-separated list. */ + QUIT; /* Allow user to bail out with ^C. */ if (*action_exp == ',') action_exp++; while (isspace ((int) *action_exp)) @@ -3039,7 +3039,7 @@ find_matching_tracepoint (struct uploaded_tp *utp) if (t->type == utp->type && t->step_count == utp->step && t->pass_count == utp->pass - /* FIXME also test conditionals and actions */ + /* FIXME also test conditionals and actions. */ ) { /* Scan the locations for an address match. */ @@ -3128,7 +3128,7 @@ create_tsv_from_upload (struct uploaded_tsv *utsv) } /* Fish for a name that is not in use. */ - /* (should check against all internal vars?) */ + /* (should check against all internal vars?) */ while (find_trace_state_variable (buf)) sprintf (buf, "%s_%d", namebase, try_num++); @@ -3220,7 +3220,7 @@ tfile_open (char *filename, int from_tty) int flags; int scratch_chan; char header[TRACE_HEADER_SIZE]; - char linebuf[1000]; /* should be max remote packet size or so */ + char linebuf[1000]; /* Should be max remote packet size or so. */ char byte; int bytes, i, gotten; struct trace_status *ts; @@ -3249,7 +3249,7 @@ tfile_open (char *filename, int from_tty) /* Looks semi-reasonable. Toss the old trace file and work on the new. */ - discard_cleanups (old_chain); /* Don't free filename any more */ + discard_cleanups (old_chain); /* Don't free filename any more. */ unpush_target (&tfile_ops); push_target (&tfile_ops); @@ -3338,7 +3338,7 @@ tfile_open (char *filename, int from_tty) post_create_inferior (&tfile_ops, from_tty); #if 0 - /* FIXME this will get defined in MI patch submission */ + /* FIXME this will get defined in MI patch submission. */ tfind_1 (tfind_number, 0, 0, 0, 0); #endif } @@ -3640,7 +3640,7 @@ tfile_close (int quitting) return; pid = ptid_get_pid (inferior_ptid); - inferior_ptid = null_ptid; /* Avoid confusion from thread stuff */ + inferior_ptid = null_ptid; /* Avoid confusion from thread stuff. */ exit_inferior_silent (pid); close (trace_fd); @@ -3652,7 +3652,7 @@ tfile_close (int quitting) static void tfile_files_info (struct target_ops *t) { - /* (it would be useful to mention the name of the file) */ + /* (it would be useful to mention the name of the file). */ printf_filtered ("Looking at a trace file.\n"); } @@ -3681,7 +3681,7 @@ tfile_get_traceframe_address (off_t tframe_offset) off_t saved_offset = cur_offset; int gotten; - /* FIXME dig pc out of collected registers */ + /* FIXME dig pc out of collected registers. */ /* Fall back to using tracepoint address. */ lseek (trace_fd, tframe_offset, SEEK_SET); @@ -3695,7 +3695,7 @@ tfile_get_traceframe_address (off_t tframe_offset) (target_gdbarch)); tp = get_tracepoint_by_number_on_target (tpnum); - /* FIXME this is a poor heuristic if multiple locations */ + /* FIXME this is a poor heuristic if multiple locations. */ if (tp && tp->loc) addr = tp->loc->address; @@ -4013,7 +4013,7 @@ tfile_xfer_partial (struct target_ops *ops, enum target_object object, /* It's unduly pedantic to refuse to look at the executable for read-only pieces; so do the equivalent of readonly regions aka QTro packet. */ - /* FIXME account for relocation at some point */ + /* FIXME account for relocation at some point. */ if (exec_bfd) { asection *s; @@ -4483,7 +4483,7 @@ at the start of tracing.")); Delete one or more trace state variables.\n\ Arguments are the names of the variables to delete.\n\ If no arguments are supplied, delete all variables."), &deletelist); - /* FIXME add a trace variable completer */ + /* FIXME add a trace variable completer. */ add_info ("tvariables", tvariables_info, _("\ Status of trace state variables and their values.\n\ |