aboutsummaryrefslogtreecommitdiff
path: root/gdb/tracepoint.c
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2010-04-19 19:51:39 +0000
committerMike Frysinger <vapier@gentoo.org>2010-04-19 19:51:39 +0000
commit0c4b2e63934787e61a17fcefbe6054286d853a06 (patch)
tree764c962928093e8cac7502865aedd510d7950e42 /gdb/tracepoint.c
parent952ad68fec3a85501955832c5d12cb9c310e63b2 (diff)
downloadgdb-0c4b2e63934787e61a17fcefbe6054286d853a06.zip
gdb-0c4b2e63934787e61a17fcefbe6054286d853a06.tar.gz
gdb-0c4b2e63934787e61a17fcefbe6054286d853a06.tar.bz2
gdb: objc-lang: check symbol name before accessing memory
The current ObjC logic will check both the symbol name and the target address space when trying to locate an appropriate selector. The problem is that first the target address space is checked before the symbol name. This may lead to a lot of unnecessary host<->target transactions when dealing with a non-OjbC target that does use function descriptors to describe functions as every symbol will have its FD read just to have the result thrown away with non-matching symbol names. It also may lead to problems when a non-FD symbol is found that points near the end of the address space as the target will throw up a memory_error(). One such example are symbols that are not functions, smaller than a FD, and are the last valid location. Obviously treating it as a larger data struct can cause memory overflows. So to speed things up and not screw over such targets, check the symbol name (which we already have locally) first before attempting to read the function's descriptor. This fixes breakpoints with Blackfin Linux FDPIC ELFs, and seems to cause no native regressions on my x86_64/Linux system. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'gdb/tracepoint.c')
0 files changed, 0 insertions, 0 deletions