diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-06-28 15:28:26 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-06-28 15:28:26 -0400 |
| commit | 0c1bcd23274e9f465dc43eda4fc467150631f824 (patch) | |
| tree | a7ebad33d064631f80c6b016da5cb3e2df3eedae /gdb/tilegx-tdep.c | |
| parent | f07fad95a949b070e51a18276b8f1e03cf86490f (diff) | |
| download | gdb-0c1bcd23274e9f465dc43eda4fc467150631f824.zip gdb-0c1bcd23274e9f465dc43eda4fc467150631f824.tar.gz gdb-0c1bcd23274e9f465dc43eda4fc467150631f824.tar.bz2 | |
gdb: convert obj_section macros to methods
Convert these three macros to methods of obj_section. The problem fixed
by the following patch is caused by an out of bound access of the
objfile::section_offsets vector. Since this is deep in macros, we don't
get a clear backtrace and it's difficult to debug. Changing that to
methods means we can step in them and break on them.
Because their implementation requires knowing about struct objfile, move
struct obj_section below struct objfile in objfiles.h.
The obj_section_offset was used in one place as an lvalue to set
offsets, in machoread.c. Replace that with a set_offset method.
Add the objfile::section_offset and objfile::set_section_offset methods
to improve encapsulation (reduce other objects poking into struct
objfile's internals).
gdb/ChangeLog:
* objfiles.h (struct obj_section): Move down.
<offset, set_offset, addr, endaddr>: New.
(obj_section_offset, obj_section_addr, obj_section_endaddr),
replace all users to use obj_section methods.
(struct objfile) <section_offset, set_section_offset>: New.
Change-Id: I97e8fcae93ab2353fbdadcb4a5ec10d7949a7334
Diffstat (limited to 'gdb/tilegx-tdep.c')
| -rw-r--r-- | gdb/tilegx-tdep.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/tilegx-tdep.c b/gdb/tilegx-tdep.c index 9bd982f..73ed1d8 100644 --- a/gdb/tilegx-tdep.c +++ b/gdb/tilegx-tdep.c @@ -747,7 +747,7 @@ tilegx_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR start_pc) s = find_pc_section (start_pc); end_pc = start_pc + 8 * TILEGX_BUNDLE_SIZE_IN_BYTES; if (s != NULL) - end_pc = std::min (end_pc, obj_section_endaddr (s)); + end_pc = std::min (end_pc, s->endaddr ()); /* Otherwise, try to skip prologue the hard way. */ return tilegx_analyze_prologue (gdbarch, |