diff options
author | Joel Brobecker <brobecker@gnat.com> | 2009-09-13 16:28:29 +0000 |
---|---|---|
committer | Joel Brobecker <brobecker@gnat.com> | 2009-09-13 16:28:29 +0000 |
commit | 005ca36a8b302b4d6da415e0cf66d5d9f684a8da (patch) | |
tree | 6b29baf5a48f0db070c34c5922c2e111ffc52a1d /gdb/thread.c | |
parent | 97b11f4094739634d104156f5c586ba7916ef0fa (diff) | |
download | gdb-005ca36a8b302b4d6da415e0cf66d5d9f684a8da.zip gdb-005ca36a8b302b4d6da415e0cf66d5d9f684a8da.tar.gz gdb-005ca36a8b302b4d6da415e0cf66d5d9f684a8da.tar.bz2 |
gdb/
* frame.c (get_frame_id): Default to outer_frame_id if the this_id
method does not supply an ID. Assert that the result is not
null_frame_id.
(outer_frame_id): New.
(frame_id_p): Accept outer_frame_id.
(frame_id_eq): Allow outer_frame_id to be equal to itself.
(frame_find_by_id): Revert previous local workarounds.
(get_prev_frame_1): Adjust end-of-stack check to test outer_frame_id.
* frame.h (null_frame_id, frame_id_p): Update comments.
(outer_frame_id): Declare.
* infrun.c (handle_inferior_event): Do not treat all steps from the
outermost frame as subroutine calls.
* libunwind-frame.c (libunwind_frame_this_id): Do not clear THIS_ID.
* hppa-tdep.c (hppa_stub_frame_this_id): Likewise.
* ia64-tdep.c (ia64_frame_this_id): Likewise.
(ia64_libunwind_frame_this_id, ia64_libunwind_sigtramp_frame_this_id):
Use outer_frame_id instead of null_frame_id.
* amd64obsd-tdep.c (amd64obsd_trapframe_cache): Use outer_frame_id.
* i386obsd-tdep.c (i386obsd_trapframe_cache): Likewise.
* inline-frame.c (inline_frame_this_id): Refuse outer_frame_id.
* thread.c (restore_selected_frame): Update comment and remove
frame_id_p check.
gdb/doc/
* gdbint.texinfo (Unwinding the Frame ID): Reference outer_frame_id.
Diffstat (limited to 'gdb/thread.c')
-rw-r--r-- | gdb/thread.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/gdb/thread.c b/gdb/thread.c index a7ac3c8..55b4b96 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -885,15 +885,11 @@ restore_selected_frame (struct frame_id a_frame_id, int frame_level) frame = find_relative_frame (get_current_frame (), &count); if (count == 0 && frame != NULL - /* Either the frame ids match, of they're both invalid. The - latter case is not failsafe, but since it's highly unlikely + /* The frame ids must match - either both valid or both outer_frame_id. + The latter case is not failsafe, but since it's highly unlikely the search by level finds the wrong frame, it's 99.9(9)% of the time (for all practical purposes) safe. */ - && (frame_id_eq (get_frame_id (frame), a_frame_id) - /* Note: could be better to check every frame_id - member for equality here. */ - || (!frame_id_p (get_frame_id (frame)) - && !frame_id_p (a_frame_id)))) + && frame_id_eq (get_frame_id (frame), a_frame_id)) { /* Cool, all is fine. */ select_frame (frame); |