diff options
| author | Tom Tromey <tom@tromey.com> | 2017-10-15 08:36:51 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2017-11-07 13:59:09 -0700 |
| commit | 95a6b0a106fac6ea35670421534d461a3663c0ba (patch) | |
| tree | d96a5ad0377d41da2c47fa8707a74406e4e10ebe /gdb/thread.c | |
| parent | eb4c3f4aaae2ee1b27c210e951260a7e699133b4 (diff) | |
| download | gdb-95a6b0a106fac6ea35670421534d461a3663c0ba.zip gdb-95a6b0a106fac6ea35670421534d461a3663c0ba.tar.gz gdb-95a6b0a106fac6ea35670421534d461a3663c0ba.tar.bz2 | |
Constify execute_command
This constifies execute_command and fixes up the callers.
gdb/ChangeLog
2017-11-07 Tom Tromey <tom@tromey.com>
* event-top.h (command_handler): Constify.
* record-full.c (cmd_record_full_start): Update.
* thread.c (thread_apply_all_command): Update.
* printcmd.c (eval_command): Update.
* mi/mi-main.c (mi_execute_cli_command): Update.
(mi_execute_async_cli_command): Update.
* tui/tui-stack.c (tui_update_command): Update.
* cli/cli-interp.c (safe_execute_command): Constify.
* record.c (record_start): Update.
(record_start, record_stop, cmd_record_start): Update.
* record-btrace.c (cmd_record_btrace_bts_start): Update.
(cmd_record_btrace_pt_start): Update.
(cmd_record_btrace_start): Update.
(cmd_record_btrace_start): Update.
* reverse.c (exec_reverse_once): Update.
* python/python.c (execute_gdb_command): Don't copy the command.
* event-top.c (command_line_handler): Update.
(command_handler): Constify.
* defs.h (deprecated_call_command_hook): Constify.
* cli/cli-script.h (execute_user_command): Constify.
* cli/cli-script.c (execute_user_command): Constify.
(execute_cmd_pre_hook, execute_cmd_post_hook): Constify.
(enum command_control_type): Update.
* main.c (catch_command_errors): Remove non-const overload.
(catch_command_errors_ftype): Remove.
* python/py-cmd.c (cmdpy_function): Constify.
* guile/scm-cmd.c (cmdscm_function): Constify.
* cli/cli-dump.c (call_dump_func): Constify.
* cli/cli-decode.c (do_const_cfunc): Constify.
(do_sfunc): Constify.
(cmd_func): Constify.
* gdbcmd.h (execute_command, execute_command_to_string): Constify.
* top.h (execute_command): Constify.
* top.c (execute_command): Constify.
(execute_command_to_string): Constify.
(deprecated_call_command_hook): Constify.
* command.h (cmd_func): Constify.
* cli/cli-decode.h (struct cmd_list_element) <func>: Constify.
Diffstat (limited to 'gdb/thread.c')
| -rw-r--r-- | gdb/thread.c | 16 |
1 files changed, 3 insertions, 13 deletions
diff --git a/gdb/thread.c b/gdb/thread.c index 1e81a61..d71568e 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1704,10 +1704,7 @@ thread_apply_all_command (const char *cmd, int from_tty) print_thread_id (thr), target_pid_to_str (inferior_ptid)); - /* Use a copy of the command in case it is clobbered by - execute_command. */ - std::string copy = cmd; - execute_command (©[0], from_tty); + execute_command (cmd, from_tty); } } } @@ -1717,7 +1714,7 @@ thread_apply_all_command (const char *cmd, int from_tty) static void thread_apply_command (const char *tidlist, int from_tty) { - char *cmd = NULL; + const char *cmd = NULL; tid_range_parser parser; if (tidlist == NULL || *tidlist == '\000') @@ -1730,7 +1727,7 @@ thread_apply_command (const char *tidlist, int from_tty) if (!parser.get_tid_range (&inf_num, &thr_start, &thr_end)) { - cmd = (char *) parser.cur_tok (); + cmd = parser.cur_tok (); break; } } @@ -1741,10 +1738,6 @@ thread_apply_command (const char *tidlist, int from_tty) if (tidlist == cmd || !isalpha (cmd[0])) invalid_thread_id_error (cmd); - /* Save a copy of the command in case it is clobbered by - execute_command. */ - std::string saved_cmd = cmd; - scoped_restore_current_thread restore_thread; parser.init (tidlist, current_inferior ()->num); @@ -1798,9 +1791,6 @@ thread_apply_command (const char *tidlist, int from_tty) printf_filtered (_("\nThread %s (%s):\n"), print_thread_id (tp), target_pid_to_str (inferior_ptid)); execute_command (cmd, from_tty); - - /* Restore exact command used previously. */ - strcpy (cmd, saved_cmd.c_str ()); } } |