diff options
author | Sergio Durigan Junior <sergiodj@redhat.com> | 2015-07-28 17:38:14 -0400 |
---|---|---|
committer | Sergio Durigan Junior <sergiodj@redhat.com> | 2015-07-28 17:39:16 -0400 |
commit | d60a92216e5d599fed6b37c58c744debe38a0b24 (patch) | |
tree | ea5bb1d8189fa7d24086cb44a62c3aaa90b8246f /gdb/testsuite | |
parent | bde40b8f563dd682b9c6bcb8e24c3f5bd944a4f6 (diff) | |
download | gdb-d60a92216e5d599fed6b37c58c744debe38a0b24.zip gdb-d60a92216e5d599fed6b37c58c744debe38a0b24.tar.gz gdb-d60a92216e5d599fed6b37c58c744debe38a0b24.tar.bz2 |
Uniquify test names from gdb.python/{py-objfile.exp,py-pp-registration.exp}
While running some regression tests, I noticed that the two Python
tests mentioned in the $SUBJECT contain non-unique names. This is a
violation of our guidelines:
<https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique>
And also makes things harder for BuildBot. So I hacked both testcases
and made every test name unique. I guess this could be considered an
obvious patch, but I decided to post it before pushing because others
may have different opinions about the names.
OK to apply?
gdb/testsuite/ChangeLog:
2015-07-28 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.python/py-objfile.exp: Make some tests have unique names.
* gdb.python/py-pp-registration.exp: Likewise.
Diffstat (limited to 'gdb/testsuite')
-rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/testsuite/gdb.python/py-objfile.exp | 15 | ||||
-rw-r--r-- | gdb/testsuite/gdb.python/py-pp-registration.exp | 11 |
3 files changed, 22 insertions, 9 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3ca42a8..34f6d8b 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-07-28 Sergio Durigan Junior <sergiodj@redhat.com> + + * gdb.python/py-objfile.exp: Make some tests have unique names. + * gdb.python/py-pp-registration.exp: Likewise. + 2015-07-28 Pedro Alves <palves@redhat.com> * gdb.server/server-exec-info.exp: Issue a "disconnect". diff --git a/gdb/testsuite/gdb.python/py-objfile.exp b/gdb/testsuite/gdb.python/py-objfile.exp index 4de20c5..7dd094c 100644 --- a/gdb/testsuite/gdb.python/py-objfile.exp +++ b/gdb/testsuite/gdb.python/py-objfile.exp @@ -46,7 +46,7 @@ gdb_test "python print (objfile.username)" "${testfile}" \ "Get objfile user name" gdb_test "python print (gdb.lookup_objfile (\"${testfile}\").filename)" \ - "${testfile}" + "${testfile}" "print lookup_objfile filename" gdb_test "python print (gdb.lookup_objfile (\"junk\"))" \ "Objfile not found\\.\r\n${python_error_text}" @@ -56,7 +56,7 @@ if [string compare $binfile_build_id ""] { gdb_test "python print (objfile.build_id)" "$binfile_build_id" \ "Get objfile build id" gdb_test "python print (gdb.lookup_objfile (\"$binfile_build_id\", by_build_id=True).filename)" \ - "${testfile}" + "${testfile}" "print lookup_objfile filename by build-id" } else { unsupported "build-id is not supported by the compiler" } @@ -64,9 +64,11 @@ if [string compare $binfile_build_id ""] { # Other lookup_objfile_by_build_id tests we can do, even if compiler doesn't # support them. gdb_test "python print (gdb.lookup_objfile (\"foo\", by_build_id=True))" \ - "Not a valid build id\\.\r\n${python_error_text}" + "Not a valid build id\\.\r\n${python_error_text}" \ + "print invalid file lookup_objfile by build-id" gdb_test "python print (gdb.lookup_objfile (\"1234abcdef\", by_build_id=True))" \ - "Objfile not found\\.\r\n${python_error_text}" + "Objfile not found\\.\r\n${python_error_text}" \ + "print invalid file lookup_objfile by build-id 2" gdb_test "python print (objfile.progspace)" "<gdb\.Progspace object at .*>" \ "Get objfile program space" @@ -104,7 +106,7 @@ if ![runto_main] { return 0 } -gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \ +gdb_py_test_silent_cmd "python objfile = gdb.s()\[0\]" \ "Get no-debug objfile file" 1 gdb_test "python print (objfile.owner)" "None" \ @@ -131,7 +133,8 @@ gdb_test "p main" "= {int \\(\\)} $hex <main>" \ # Separate debug files are not findable. if { [get_python_valueof "sep_objfile.build_id" "None"] != "None" } { gdb_test "python print (gdb.lookup_objfile (sep_objfile.build_id, by_build_id=True))" \ - "Objfile not found\\.\r\n${python_error_text}" + "Objfile not found\\.\r\n${python_error_text}" \ + "print lookup_objfile of separate debug file" } # An objfile that was a symlink to a differently named file is still diff --git a/gdb/testsuite/gdb.python/py-pp-registration.exp b/gdb/testsuite/gdb.python/py-pp-registration.exp index 2193407..60f3436 100644 --- a/gdb/testsuite/gdb.python/py-pp-registration.exp +++ b/gdb/testsuite/gdb.python/py-pp-registration.exp @@ -46,7 +46,8 @@ proc prepare_test { } { return 0 } - gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" + gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" \ + "read file" gdb_test_no_output "py progspace = gdb.current_progspace()" gdb_test_no_output "py my_pretty_printer1 = build_pretty_printer1()" @@ -108,9 +109,13 @@ with_test_prefix "replace" { gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=False)" \ "RuntimeError: pretty-printer already registered: pp-test\r\nError while executing Python code." - test_printers "s1" + with_test_prefix "test printers 1" { + test_printers "s1" + } gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=True)" - test_printers "s2" + with_test_prefix "test printers 2" { + test_printers "s2" + } } |