diff options
| author | Tom de Vries <tdevries@suse.de> | 2020-02-04 09:53:50 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2020-02-04 09:53:50 +0100 |
| commit | 780636aec079208cd8ee1079f27d0d5ac5dae48a (patch) | |
| tree | a431e0ba5708c12196eb031e65849f028e70821c /gdb/testsuite | |
| parent | 719546c44f5777a3902a2f913c70fd15b942461d (diff) | |
| download | gdb-780636aec079208cd8ee1079f27d0d5ac5dae48a.zip gdb-780636aec079208cd8ee1079f27d0d5ac5dae48a.tar.gz gdb-780636aec079208cd8ee1079f27d0d5ac5dae48a.tar.bz2 | |
[gdb/testsuite] Use non-capturing parentheses for inferior_exited_re
The inferior_exited_re regexp uses capturing parentheses by default:
...
set inferior_exited_re "(\\\[Inferior \[0-9\]+ \\(.*\\) exited)"
...
The parentheses are there to be able to use the expression as an atom, f.i.,
to have '+' apply to the whole regexp in "${inferior_exited_re}+".
But the capturing is not necessary, and it can be confusing because it's not
obvious in a regexp using "$inferior_exited_re (bla|bli)" that the first
captured expression is in $inferior_exited_re.
Replace by non-capturing parentheses. If we still want to capture the
expression, we can simply (and more clearly) use "($inferior_exited_re)".
Build and reg-tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-02-04 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (inferior_exited_re): Use non-capturing parentheses.
Change-Id: I7640c6129b1ada617424d6a63730d4b119c58ef3
Diffstat (limited to 'gdb/testsuite')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 2b1a8ba..bc61679 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-02-04 Tom de Vries <tdevries@suse.de> + + * lib/gdb.exp (inferior_exited_re): Use non-capturing parentheses. + 2020-02-03 Rogerio A. Cardoso <rcardoso@linux.ibm.com> * gdb.arch/powerpc-power8.exp: Delete trailing whitespace of diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 2d230b7..25bed76 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -117,7 +117,7 @@ if ![info exists env(EXEEXT)] { set octal "\[0-7\]+" -set inferior_exited_re "(\\\[Inferior \[0-9\]+ \\(.*\\) exited)" +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)" # A regular expression that matches a value history number. # E.g., $1, $2, etc. |