diff options
author | Kevin Buettner <kevinb@redhat.com> | 2019-03-20 20:38:33 -0700 |
---|---|---|
committer | Kevin Buettner <kevinb@redhat.com> | 2019-04-08 20:21:34 -0700 |
commit | 2b0c8b019996b23fb4717687f5e7ac8c5620c089 (patch) | |
tree | 27f4cf53d2e1f632def4eea8f081c92bdd22c88c /gdb/testsuite | |
parent | c369f8f0face23a06e0cf114bf70a024ba9b4959 (diff) | |
download | gdb-2b0c8b019996b23fb4717687f5e7ac8c5620c089.zip gdb-2b0c8b019996b23fb4717687f5e7ac8c5620c089.tar.gz gdb-2b0c8b019996b23fb4717687f5e7ac8c5620c089.tar.bz2 |
Rename python function thread_from_thread_handle to thread_from_handle
This renaming was done to stay consistent with the naming of the new
gdb.InferiorThread.handle method. I had initially named it "thread_handle"
but Tom Tromey suggested just "handle".
The old name (thread_from_thread_handle) still works, but is marked as
deprecated in comments in the code as well as in the documentation.
I have some code which uses these functions. I very much like the
brevity of the new names.
gdb/doc/ChangeLog:
* python.texi (Inferiors In Python): Rename
Inferior.thread_from_thread_handle to Inferior.thread_from_handle.
Add note about the former being deprecated.
gdb/ChangeLog:
* python/py-inferior.c (infpy_thread_from_thread_handle):
Adjust comments to reflect renaming of thread_from_thread_handle
to thread_from_handle. Adjust keywords. Fix type error message.
(inferior_object_methods): Add thread_from_handle. Retain
thread_from_thread_handle, but mark it as deprecated.
testsuite/ChangeLog:
* gdb.python/py-thrhandle.exp: Adjust tests to call
thread_from_handle instead of thread_from_thread_handle.
Diffstat (limited to 'gdb/testsuite')
-rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/testsuite/gdb.python/py-thrhandle.exp | 30 |
2 files changed, 20 insertions, 15 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8c5739f..5f1ce3c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2019-04-08 Kevin Buettner <kevinb@redhat.com> + * gdb.python/py-thrhandle.exp: Adjust tests to call + thread_from_handle instead of thread_from_thread_handle. + +2019-04-08 Kevin Buettner <kevinb@redhat.com> + * gdb.python/py-thrhandle.exp: Add tests for gdb.InferiorThread.handle. diff --git a/gdb/testsuite/gdb.python/py-thrhandle.exp b/gdb/testsuite/gdb.python/py-thrhandle.exp index 57b97fa..19c690b 100644 --- a/gdb/testsuite/gdb.python/py-thrhandle.exp +++ b/gdb/testsuite/gdb.python/py-thrhandle.exp @@ -16,7 +16,7 @@ # Please email any bugs, comments, and/or additions to this file to: # bug-gdb@gnu.org -# This file verifies that methods Inferior.thread_from_thread_handle +# This file verifies that methods Inferior.thread_from_handle # and InferiorThread.handle work as expected. load_lib gdb-python.exp @@ -67,44 +67,44 @@ gdb_test "info threads" \ {.*[\r\n]+\* +([0-9]+) +Thread[^\r\n]* do_something \(n=\1\) at.*} # Check for expected results when passing a valid thread handle to -# thread_from_thread_handle(). +# thread_from_handle(). -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('thrs\[0\]')).num)" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('thrs\[0\]')).num)" \ "1" "print thread id for thrs\[0\]" -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('thrs\[1\]')).num)" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('thrs\[1\]')).num)" \ "2" "print thread id for thrs\[1\]" -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('thrs\[2\]')).num)" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('thrs\[2\]')).num)" \ "3" "print thread id for thrs\[2\]" # Objects which are of the correct size, but which are bogus thread # handles should return None. For the first test (using thrs[3]), we # use 0. For the second (thrs[4]), we use an unlikely bit pattern. -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('thrs\[3\]')))" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('thrs\[3\]')))" \ "None" "print thread for bogus handle thrs\[3\]" -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('thrs\[4\]')))" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('thrs\[4\]')))" \ "None" "print thread for bogus handle thrs\[4\]" # We should see an exception when passing an object of the wrong type. -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.lookup_symbol('main')))" \ - ".*TypeError: Argument 'handle_obj' must be a thread handle object.*" \ - "TypeError when passing a symbol object to thread_from_thread_handle" +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.lookup_symbol('main')))" \ + ".*TypeError: Argument 'handle' must be a thread handle object.*" \ + "TypeError when passing a symbol object to thread_from_handle" # We should see an exception when passing too large of an object. -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('thrs')))" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('thrs')))" \ ".*Thread handle size mismatch.*" \ - "Pass overly large object to thread_from_thread_handle" + "Pass overly large object to thread_from_handle" # We should see an exception when passing too small of an object. -gdb_test "python print(gdb.selected_inferior().thread_from_thread_handle(gdb.parse_and_eval('\"S\"')))" \ +gdb_test "python print(gdb.selected_inferior().thread_from_handle(gdb.parse_and_eval('\"S\"')))" \ ".*Thread handle size mismatch.*" \ - "Pass too small of an object to thread_from_thread_handle" + "Pass too small of an object to thread_from_handle" # Test the thread_handle method @@ -121,7 +121,7 @@ foreach thrN {0 1 2} { 1 gdb_py_test_silent_cmd \ - "python hand_bytes = inf.thread_from_thread_handle(hand).handle()" \ + "python hand_bytes = inf.thread_from_handle(hand).handle()" \ "fetch thread handle from thread" \ 1 |