diff options
| author | Tom de Vries <tdevries@suse.de> | 2020-05-25 17:27:49 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2020-05-25 17:27:49 +0200 |
| commit | 42cf184456fb1470835b6dccd536c2d74461e7b6 (patch) | |
| tree | dfdd8e62015486a89582df5de10f02816bad2f4b /gdb/testsuite | |
| parent | 07e0bb0fb2a900d8eecc3a51e3b21349217a8992 (diff) | |
| download | gdb-42cf184456fb1470835b6dccd536c2d74461e7b6.zip gdb-42cf184456fb1470835b6dccd536c2d74461e7b6.tar.gz gdb-42cf184456fb1470835b6dccd536c2d74461e7b6.tar.bz2 | |
[gdb/testsuite] Add comment in exec_is_pie
Add comment to exec_is_pie explaining why readelf -d output is not used.
gdb/testsuite/ChangeLog:
2020-05-25 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (exec_is_pie): Add comment.
Diffstat (limited to 'gdb/testsuite')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 91769e8..201f268 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2020-05-25 Tom de Vries <tdevries@suse.de> + * lib/gdb.exp (exec_is_pie): Add comment. + +2020-05-25 Tom de Vries <tdevries@suse.de> + * lib/jit-elf-helpers.exp (compile_and_download_n_jit_so): Use $f instead of $binfile in the untested message. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 7177be9..8e22941 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5509,6 +5509,9 @@ proc exec_is_pie { executable } { return -1 } set readelf_program [gdb_find_readelf] + # We're not testing readelf -d | grep "FLAGS_1.*Flags:.*PIE" + # because the PIE flag is not set by all versions of gold, see PR + # binutils/26039. set res [catch {exec $readelf_program -h $executable} output] if { $res != 0 } { return -1 |