diff options
author | Hannes Domani <ssbssa@yahoo.de> | 2020-05-05 14:31:26 +0200 |
---|---|---|
committer | Hannes Domani <ssbssa@yahoo.de> | 2020-10-05 14:30:29 +0200 |
commit | cd096ec85fb3aedf5cf9c3c116a7deab2ee0d388 (patch) | |
tree | 304be0048ed54af1d077f2ac313039c8ed3ab39f /gdb/testsuite | |
parent | 5b316d90e4ec9845a890fd21ad86cf1043fb2ca3 (diff) | |
download | gdb-cd096ec85fb3aedf5cf9c3c116a7deab2ee0d388.zip gdb-cd096ec85fb3aedf5cf9c3c116a7deab2ee0d388.tar.gz gdb-cd096ec85fb3aedf5cf9c3c116a7deab2ee0d388.tar.bz2 |
Fix function argument and return value locations
Fixes these testsuite fails on Windows:
FAIL: gdb.base/callfuncs.exp: p t_float_complex_values(fc1, fc2)
FAIL: gdb.base/callfuncs.exp: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4)
FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_values(fc1, fc2)
FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4)
FAIL: gdb.base/call-sc.exp: p/c fun(); call call-sc-tld
FAIL: gdb.base/call-sc.exp: advance to fun for return; return call-sc-tld
FAIL: gdb.base/call-sc.exp: zed L for return; return call-sc-tld
FAIL: gdb.base/call-sc.exp: return foo; return call-sc-tld
FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'call-sc-tld'
FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'call-sc-tld'
FAIL: gdb.base/call-sc.exp: advance to fun for finish; return call-sc-tld
FAIL: gdb.base/call-sc.exp: zed L for finish; return call-sc-tld
FAIL: gdb.base/call-sc.exp: finish foo; return call-sc-tld (the program is no longer running)
FAIL: gdb.base/call-sc.exp: value foo finished; return call-sc-tld
For function arguments (callfuncs.exp), only TYPE_CODE_COMPLEX was
missing in the types passed via integer registers.
For return values, there were a lot more issues:
- TYPE_CODE_DECFLOAT is NOT returned via XMM0.
- long double is NOT returned via XMM0.
- but __int128 IS returned via XMM0.
- the comments for TYPE_CODE_FLT state that __m128, __m128i and __m128d are
returned by XMM0, and this is correct, but it doesn't actually check for
them, because they are TYPE_CODE_ARRAY with TYPE_VECTOR
So I had to add TYPE_CODE_DECFLOAT to the arguments passed via XMM register,
but I had to remove it from the values returned via XMM0 register.
gdb/ChangeLog:
2020-10-05 Hannes Domani <ssbssa@yahoo.de>
* amd64-windows-tdep.c (amd64_windows_passed_by_integer_register):
Add TYPE_CODE_COMPLEX.
(amd64_windows_return_value): Fix types returned via XMM0.
gdb/testsuite/ChangeLog:
2020-10-05 Hannes Domani <ssbssa@yahoo.de>
* gdb.base/call-sc.c: Fix return struct on stack test case.
* gdb.base/call-sc.exp: Likewise.
Diffstat (limited to 'gdb/testsuite')
-rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/call-sc.c | 6 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/call-sc.exp | 13 |
3 files changed, 23 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a330b0c..e8fe944 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-10-05 Hannes Domani <ssbssa@yahoo.de> + + * gdb.base/call-sc.c: Fix return struct on stack test case. + * gdb.base/call-sc.exp: Likewise. + 2020-10-02 Gary Benson <gbenson@redhat.com> * README: Fix "paralell". diff --git a/gdb/testsuite/gdb.base/call-sc.c b/gdb/testsuite/gdb.base/call-sc.c index ba80576..eb140cd 100644 --- a/gdb/testsuite/gdb.base/call-sc.c +++ b/gdb/testsuite/gdb.base/call-sc.c @@ -35,6 +35,7 @@ typedef t T; #endif T foo = '1', L; +T init = '9'; T fun() { @@ -55,7 +56,10 @@ int main() { int i; - Fun(foo); + /* Use a different initial value then is later used in the + "value foo returned" test, so in case the struct is then returned + on the stack, it doesn't have the correct value by accident. */ + Fun(init); /* An infinite loop that first clears all the variables and then calls the function. This "hack" is to make re-testing easier - diff --git a/gdb/testsuite/gdb.base/call-sc.exp b/gdb/testsuite/gdb.base/call-sc.exp index 9544dcc..685c6f2 100644 --- a/gdb/testsuite/gdb.base/call-sc.exp +++ b/gdb/testsuite/gdb.base/call-sc.exp @@ -280,6 +280,19 @@ proc test_scalar_returns { } { fail "${test}" } } + -re " = 57 .*${gdb_prompt} $" { + if $return_value_unknown { + # The struct return case. + # The return value is stored on the stack, and since GDB + # didn't override it, it still has value that was stored + # there in the earlier Foo(init) call. + pass "${test}" + } else { + # This contradicts the above claim that GDB knew + # the location of the return-value. + fail "${test}" + } + } -re ".*${gdb_prompt} $" { if $return_value_unimplemented { # What a suprize. The architecture hasn't implemented |