diff options
| author | Jose E. Marchesi <jose.marchesi@oracle.com> | 2015-02-17 15:50:19 +0100 |
|---|---|---|
| committer | Jose E. Marchesi <jose.marchesi@oracle.com> | 2015-02-17 15:50:19 +0100 |
| commit | 03e98035a2a5d928ceb36ddd7b43369fbf72a008 (patch) | |
| tree | b3173b4506e27e0e1fca3ecd82d73c36521445ef /gdb/testsuite | |
| parent | 6f9b84910f8cabf565598f499258bbea51cc06d4 (diff) | |
| download | gdb-03e98035a2a5d928ceb36ddd7b43369fbf72a008.zip gdb-03e98035a2a5d928ceb36ddd7b43369fbf72a008.tar.gz gdb-03e98035a2a5d928ceb36ddd7b43369fbf72a008.tar.bz2 | |
Move `compute_probe_arg' and `compile_probe_arg' to probe.c
This patch moves the `compute_probe_arg' and `compile_probe_arg' functions
from stap-probe.c to probe.c. The rationale is that it is reasonable to
assume that all backends will provide the `$_probe_argN' convenience
variables, and that the user must be placed on the PC of the probe when
requesting that information. The value and type of the argument can still be
determined by the probe backend via the `pops->evaluate_probe_argument' and
`pops->compile_to_ax' handlers.
Note that a test in gdb.base/stap-probe.exp had to be adjusted because the "No
SystemTap probe at PC" messages are now "No probe at PC".
gdb/ChangeLog:
2015-02-17 Jose E. Marchesi <jose.marchesi@oracle.com>
* probe.c (compute_probe_arg): Moved from stap-probe.c
(compile_probe_arg): Likewise.
(probe_funcs): Likewise.
* stap-probe.c (compute_probe_arg): Moved to probe.c.
(compile_probe_arg): Likewise.
(probe_funcs): Likewise.
gdb/testsuite/ChangeLog:
2015-02-17 Jose E. Marchesi <jose.marchesi@oracle.com>
* gdb.base/stap-probe.exp (stap_test): Remove "SystemTap" from
expected message when trying to access $_probe_* convenience
variables while not on a probe.
Diffstat (limited to 'gdb/testsuite')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/stap-probe.exp | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 4693abe..b26baad 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-02-17 Jose E. Marchesi <jose.marchesi@oracle.com> + + * gdb.base/stap-probe.exp (stap_test): Remove "SystemTap" from + expected message when trying to access $_probe_* convenience + variables while not on a probe. + 2015-02-11 Jan Kratochvil <jan.kratochvil@redhat.com> * gdb.python/py-framefilter.exp (pagination quit - *): New tests. diff --git a/gdb/testsuite/gdb.base/stap-probe.exp b/gdb/testsuite/gdb.base/stap-probe.exp index 73e6ca3..7310b25 100644 --- a/gdb/testsuite/gdb.base/stap-probe.exp +++ b/gdb/testsuite/gdb.base/stap-probe.exp @@ -30,7 +30,7 @@ proc stap_test {exec_name {arg ""}} { return -1 } - gdb_test "print \$_probe_argc" "No SystemTap probe at PC $hex" \ + gdb_test "print \$_probe_argc" "No probe at PC $hex" \ "check argument not at probe point" gdb_test "info probes stap" \ |