diff options
| author | Doug Evans <dje@google.com> | 2016-10-06 12:12:33 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2016-10-06 12:12:33 +0100 |
| commit | ee8da4b8396d9a74d27cb9bb0f3aa43d6d23b8ea (patch) | |
| tree | 1fd455f93881201680ad490eb1e54d62647b33d6 /gdb/testsuite/gdb.xml | |
| parent | 3ac6b810d1e58fe10ee496fdb1ebd4ce050dc91c (diff) | |
| download | gdb-ee8da4b8396d9a74d27cb9bb0f3aa43d6d23b8ea.zip gdb-ee8da4b8396d9a74d27cb9bb0f3aa43d6d23b8ea.tar.gz gdb-ee8da4b8396d9a74d27cb9bb0f3aa43d6d23b8ea.tar.bz2 | |
Make "end" field in feature specs required again.
Newer gdbservers may be talking to older gdbs,
and older gdbs will flag a missing "end" as an error.
So just make "end" required again, and for compatibility
change the default field type to "bool".
gdb/ChangeLog:
2016-10-06 Doug Evans <dje@google.com>
* features/aarch64-core.xml (cpsr_flags): Elide "type" and specify
"end" in all fields.
* features/aarch64.c: Regenerate.
* features/i386/32bit-mpx.xml (_bndcfgu): Specify type of "preserved"
and "enabled" fields. Correct size of "enabled" field.
* features/i386/64bit-mpx.xml (_bndcfgu): Specify type of "preserved"
and "enabled" fields.
* features/i386/i386-avx-mpx-linux.c: Regenerate.
* features/i386/i386-avx-mpx.c: Regenerate.
* features/i386/i386-avx512-linux.c: Regenerate.
* features/i386/i386-avx512.c: Regenerate.
* features/i386/i386-mpx-linux.c: Regenerate.
* features/i386/i386-mpx.c: Regenerate.
* features/arc-arcompact.c: Regenerate.
* features/arc-v2.c: Regenerate.
* xml-tdesc.c (tdesc_start_field): Require "end" spec. Single bit
fields default to "bool" type.
Revert 2016-03-15 Doug Evans <dje@google.com>
* features/i386/32bit-core.xml (i386_eflags): Remove "end" spec.
* features/i386/32bit-sse.xml (i386_eflags): Ditto.
* features/i386/64bit-core.xml (i386_eflags): Ditto.
* features/i386/64bit-sse.xml (i386_eflags): Ditto.
* features/i386/x32-core.xml (i386_eflags): Ditto.
gdb/doc/ChangeLog:
2016-10-06 Doug Evans <dje@google.com>
* gdb.texinfo (Target Description Format): Update docs on "end"
field spec and field default type.
gdb/testsuite/ChangeLog:
2016-10-06 Doug Evans <dje@google.com>
* gdb.xml/extra-regs.xml: Update, end field now required, default type
for single bitfields is bool.
* gdb.xml/tdesc-regs.exp: Ditto.
Diffstat (limited to 'gdb/testsuite/gdb.xml')
| -rw-r--r-- | gdb/testsuite/gdb.xml/extra-regs.xml | 24 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.xml/tdesc-regs.exp | 4 |
2 files changed, 13 insertions, 15 deletions
diff --git a/gdb/testsuite/gdb.xml/extra-regs.xml b/gdb/testsuite/gdb.xml/extra-regs.xml index cbbaf76..997d659 100644 --- a/gdb/testsuite/gdb.xml/extra-regs.xml +++ b/gdb/testsuite/gdb.xml/extra-regs.xml @@ -15,12 +15,12 @@ <struct id="struct2" size="8"> <field name="f1" start="0" end="34"/> - <field name="f2" start="63" end="63"/> + <field name="f2" start="63" end="63" type="uint64"/> </struct> <flags id="flags" size="4"> <field name="X" start="0" end="0"/> - <field name="Y" start="2" end="2"/> + <field name="Y" start="2" end="2" type="uint32"/> </flags> <enum id="Z_values" size="4"> @@ -31,18 +31,16 @@ </enum> <flags id="mixed_flags" size="4"> - <!-- Elided end and type. --> - <field name="A" start="0"/> - <!-- Elided end, unsigned int. --> - <field name="B" start="1" type="uint32"/> - <!-- Elided end, bool. --> - <field name="C" start="2" type="bool"/> - <!-- Elided type, single bitfield. --> - <field name="D" start="3" end="3"/> + <!-- Elided type. --> + <field name="A" start="0" end="0"/> + <!-- Elided type, multiple bits. --> + <field name="B" start="1" end="3"/> + <!-- Bool. --> + <field name="C" start="4" end="4" type="bool"/> + <!-- Unsigned int. --> + <field name="D" start="5" end="5" type="uint32"/> <!-- Anonymous field. --> - <field name="" start="4" end="5"/> - <!-- Multi-bit bitfield, elided type. --> - <field name="E" start="6" end="7"/> + <field name="" start="6" end="7"/> <!-- Enum bitfield. --> <field name="Z" start="8" end="9" type="Z_values"/> </flags> diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp index 311917f..8e0e1c9 100644 --- a/gdb/testsuite/gdb.xml/tdesc-regs.exp +++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp @@ -174,9 +174,9 @@ gdb_test "ptype \$structreg.v4" "type = int8_t __attribute__ \\(\\(vector_size\\ gdb_test "ptype \$bitfields" \ "type = struct struct2 {\r\n *uint64_t f1 : 35;\r\n *uint64_t f2 : 1;\r\n}" gdb_test "ptype \$flags" \ - "type = flag flags {\r\n *uint32_t X @0;\r\n *uint32_t Y @2;\r\n}" + "type = flag flags {\r\n *bool X @0;\r\n *uint32_t Y @2;\r\n}" gdb_test "ptype \$mixed_flags" \ - "type = flag mixed_flags {\r\n *bool A @0;\r\n *uint32_t B @1;\r\n *bool C @2;\r\n *uint32_t D @3;\r\n *uint32_t @4-5;\r\n *uint32_t E @6-7;\r\n *enum {yes = 1, no = 0, maybe = 2, so} Z @8-9;\r\n}" + "type = flag mixed_flags {\r\n *bool A @0;\r\n *uint32_t B @1-3;\r\n *bool C @4;\r\n *uint32_t D @5;\r\n *uint32_t @6-7;\r\n *enum {yes = 1, no = 0, maybe = 2, so} Z @8-9;\r\n}" load_description "core-only.xml" "" "test-regs.xml" # The extra register from the previous description should be gone. |