diff options
author | Tom de Vries <tdevries@suse.de> | 2021-10-06 11:26:38 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2021-10-06 11:26:38 +0200 |
commit | cf2ad3e66286c9f3dc8cb6cf74a2af761cb7a49f (patch) | |
tree | 1ca193b0919b1e3f10f629e8874ceec982376ff3 /gdb/testsuite/gdb.tui | |
parent | 1992e26ec4498bdd08fa960b449f6fa29e5759fa (diff) | |
download | gdb-cf2ad3e66286c9f3dc8cb6cf74a2af761cb7a49f.zip gdb-cf2ad3e66286c9f3dc8cb6cf74a2af761cb7a49f.tar.gz gdb-cf2ad3e66286c9f3dc8cb6cf74a2af761cb7a49f.tar.bz2 |
[gdb/testsuite] Fix FAIL in gdb.tui/corefile-run.exp
When running test-case gdb.tui/corefile-run.exp on openSUSE Tumbleweed,
I run into:
...
PASS: gdb.tui/corefile-run.exp: load corefile
FAIL: gdb.tui/corefile-run.exp: run until the end
...
What's going on is easier to see when also doing dump_screen if
check_contents passes, and inspecting state at the preceding PASS:
...
+-------------------------------------------------------------------------+
exec No process In: L?? PC: ??
[New LWP 16629]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/data/gdb_versions/devel/build/gdb/testsuite/output
s/gdb.tui/corefile-run/corefi'.
Program terminated with signal SIGTRAP, Trace/breakpoint trap.
#0 main ()
--Type <RET> for more, q to quit, c to continue without paging--
...
The problem is that we're getting a pagination prompt, and the subsequent run
command is interpreted as an answer to that prompt.
Fix this by:
- detecting the gdb prompt in response to "load corefile", such that
we detect the failure earlier, and
- doing a "set pagination off" in Term::clean_restart.
Tested on x86_64-linux.
Diffstat (limited to 'gdb/testsuite/gdb.tui')
-rw-r--r-- | gdb/testsuite/gdb.tui/corefile-run.exp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.tui/corefile-run.exp b/gdb/testsuite/gdb.tui/corefile-run.exp index f000ff6..d3eaaaf 100644 --- a/gdb/testsuite/gdb.tui/corefile-run.exp +++ b/gdb/testsuite/gdb.tui/corefile-run.exp @@ -54,7 +54,7 @@ gdb_assert {![string match "No Source Available" $text]} \ "initial source listing" Term::command "core-file $core" -Term::check_contents "load corefile" "21 *return 0" +Term::check_contents "load corefile" "21 *return 0.*$gdb_prompt .*" Term::command "run" Term::check_contents "run until the end" \ |