diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2015-11-23 18:47:09 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2015-11-23 18:47:09 -0500 |
| commit | c93e8391bf595de7adde64d1b3f1d564da6f3aee (patch) | |
| tree | 702b8affbc88020c0b8298f481ad8ebe9cb9a4a1 /gdb/testsuite/gdb.trace | |
| parent | 045ccf910b4345a1cfa9f3d3af20ae4d8d1defa2 (diff) | |
| download | gdb-c93e8391bf595de7adde64d1b3f1d564da6f3aee.zip gdb-c93e8391bf595de7adde64d1b3f1d564da6f3aee.tar.gz gdb-c93e8391bf595de7adde64d1b3f1d564da6f3aee.tar.bz2 | |
Fix internal error when saving fast tracepoint definitions
When trying to save fast tracepoints to file, gdb returns internal failure:
gdb/breakpoint.c:13446: internal-error: unhandled tracepoint type 27
A problem internal to GDB has been detected, further debugging may prove unreliable.
And no file including the fast tracepoints definition is created.
The patch also extends save-trace.exp to test saving tracepoint with a
fast tracepoint in there. Note that because this test doesn't actually
inserts the tracepoints in the program, we can run it with targets that
don't actually support fast tracepoints (or tracepoints at all).
gdb/ChangeLog:
* breakpoint.c (tracepoint_print_recreate): Fix logic error
if -> else if.
gdb/testsuite/ChangeLog:
* gdb.trace/actions.c: Include trace-common.h.
(main): Add a location for a fast tracepoint.
* gdb.trace/save-trace.exp: Set a fast tracepoint in addition to
the normal tracepoints.
(gdb_verify_tracepoints): Adjust number of expected tracepoints.
Diffstat (limited to 'gdb/testsuite/gdb.trace')
| -rw-r--r-- | gdb/testsuite/gdb.trace/actions.c | 4 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.trace/save-trace.exp | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.trace/actions.c b/gdb/testsuite/gdb.trace/actions.c index 4b7b887..e728635 100644 --- a/gdb/testsuite/gdb.trace/actions.c +++ b/gdb/testsuite/gdb.trace/actions.c @@ -21,6 +21,8 @@ #include <string.h> +#include "trace-common.h" + static char gdb_char_test; static short gdb_short_test; static long gdb_long_test; @@ -136,6 +138,8 @@ main (argc, argv, envp) int i; unsigned long myparms[10]; + FAST_TRACEPOINT_LABEL (fast_tracepoint_loc); + begin (); for (i = 0; i < sizeof (myparms) / sizeof (myparms[0]); i++) myparms[i] = i; diff --git a/gdb/testsuite/gdb.trace/save-trace.exp b/gdb/testsuite/gdb.trace/save-trace.exp index aade1ed..e423968 100644 --- a/gdb/testsuite/gdb.trace/save-trace.exp +++ b/gdb/testsuite/gdb.trace/save-trace.exp @@ -76,6 +76,10 @@ foreach x { 1 2 3 4 5 6 } { "end" "^$" } +gdb_test "ftrace fast_tracepoint_loc" \ + "Fast tracepoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set a fast tracepoint" + gdb_test_no_output "set default-collect gdb_char_test, gdb_long_test - 100" \ "set default-collect" @@ -116,7 +120,7 @@ proc gdb_verify_tracepoints { testname } { exp_continue } -re "$gdb_prompt $" { - if { $ourstate >= 6 } { + if { $ourstate >= 7 } { set result "pass" } else { set result "fail" |