diff options
| author | Pedro Alves <pedro@palves.net> | 2022-03-30 14:31:56 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2022-05-17 10:31:36 +0100 |
| commit | 1fe69430d166bf287fe94a7fcecc7f867666ae5a (patch) | |
| tree | 85b556882be943eedc44d80f75d57d0bedf00563 /gdb/testsuite/gdb.python | |
| parent | 35b72e4e5baabef35b34db7f12c627e7232ee204 (diff) | |
| download | gdb-1fe69430d166bf287fe94a7fcecc7f867666ae5a.zip gdb-1fe69430d166bf287fe94a7fcecc7f867666ae5a.tar.gz gdb-1fe69430d166bf287fe94a7fcecc7f867666ae5a.tar.bz2 | |
Fix bogus gdb_test invocations
A following patch will make gdb_test error out if bogus arguments are
passed, which exposed bugs in a few testcases:
- gdb.python/py-parameter.exp, passing a spurious "1" as extra
parameter, resulting in:
ERROR: Unexpected arguments: {set test-file-param bar.txt} {The name of the file has been changed to bar.txt} {set new file parameter} 1
- gdb.python/py-xmethods.exp, a missing test message, resulting in
the next gdb_test being interpreted as message, question and
response! With the enforcing patch, this was caught with:
ERROR: Unexpected arguments: {p g.mul<char>('a')} {From Python G<>::mul.*} gdb_test {p g_ptr->mul<char>('a')} {From Python G<>::mul.*} {after: g_ptr->mul<char>('a')}
- gdb.base/pointers.exp, missing a quote.
Change-Id: I66f2db4412025a64121db7347dfb0b48240d46d4
Diffstat (limited to 'gdb/testsuite/gdb.python')
| -rw-r--r-- | gdb/testsuite/gdb.python/py-parameter.exp | 2 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.python/py-xmethods.exp | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.python/py-parameter.exp b/gdb/testsuite/gdb.python/py-parameter.exp index 98d4b2d..199d3bc 100644 --- a/gdb/testsuite/gdb.python/py-parameter.exp +++ b/gdb/testsuite/gdb.python/py-parameter.exp @@ -199,7 +199,7 @@ proc_with_prefix test_file_parameter { } { "The name of the file is foo.txt.*" "show initial file value" gdb_test "set test-file-param bar.txt" \ "The name of the file has been changed to bar.txt" \ - "set new file parameter" 1 + "set new file parameter" gdb_test "show test-file-param" \ "The name of the file is bar.txt.*" "show new file value" gdb_test "python print (test_file_param.value)" \ diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp index f879e9c..1805778 100644 --- a/gdb/testsuite/gdb.python/py-xmethods.exp +++ b/gdb/testsuite/gdb.python/py-xmethods.exp @@ -130,6 +130,7 @@ gdb_test "p g.size_mul< 5 >()" "From Python G<>::size_mul.*" \ gdb_test "p g.mul<double>(2.0)" "From Python G<>::mul.*" \ "after: g.mul<double>(2.0)" gdb_test "p g.mul<char>('a')" "From Python G<>::mul.*" \ + "after: g.mul<char>('a')" gdb_test "p g_ptr->mul<char>('a')" "From Python G<>::mul.*" \ "after: g_ptr->mul<char>('a')" |