diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 11:52:21 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 15:27:39 -0400 |
| commit | 4dfef5be6812dd7abfbc8f18e9c0384f2522b511 (patch) | |
| tree | 90aa986d915c17f2320655298e2799d3a2cd1841 /gdb/testsuite/gdb.opt | |
| parent | 2fed9db40b1179f62c6fb0f2cacfb0db6b50af46 (diff) | |
| download | gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.zip gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.gz gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.bz2 | |
gdb/testsuite: make runto_main not pass no-message to runto
As follow-up to this discussion:
https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html
... make runto_main not pass no-message to runto. This means that if we
fail to run to main, for some reason, we'll emit a FAIL. This is the
behavior we want the majority of (if not all) the time.
Without this, we rely on tests logging a failure if runto_main fails,
otherwise. They do so in a very inconsisteny mannet, sometimes using
"fail", "unsupported" or "untested". The messages also vary widly.
This patch removes all these messages as well.
Also, remove a few "fail" where we call runto (and not runto_main). by
default (without an explicit no-message argument), runto prints a
failure already. In two places, gdb.multi/multi-re-run.exp and
gdb.python/py-pp-registration.exp, remove "message" passed to runto.
This removes a few PASSes that we don't care about (but FAILs will still
be printed if we fail to run to where we want to). This aligns their
behavior with the rest of the testsuite.
Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
Diffstat (limited to 'gdb/testsuite/gdb.opt')
| -rw-r--r-- | gdb/testsuite/gdb.opt/clobbered-registers-O2.exp | 1 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.opt/inline-break.exp | 5 |
2 files changed, 0 insertions, 6 deletions
diff --git a/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp b/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp index 8ad7257..b63cd9c 100644 --- a/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp +++ b/gdb/testsuite/gdb.opt/clobbered-registers-O2.exp @@ -32,7 +32,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ } if { ![runto start_sequence] } then { - fail "run to start_sequence" return } diff --git a/gdb/testsuite/gdb.opt/inline-break.exp b/gdb/testsuite/gdb.opt/inline-break.exp index c96966e..9804b63 100644 --- a/gdb/testsuite/gdb.opt/inline-break.exp +++ b/gdb/testsuite/gdb.opt/inline-break.exp @@ -191,7 +191,6 @@ foreach_with_prefix cmd [list "break" "tbreak"] { # Start with a clean state. delete_breakpoints if {![runto_main]} { - untested "could not run to main" return -1 } @@ -247,7 +246,6 @@ foreach_with_prefix func { clean_restart $binfile if {![runto_main]} { - untested "could not run to main" continue } @@ -265,7 +263,6 @@ with_test_prefix "line number" { clean_restart $binfile if {![runto_main]} { - untested "could not run to main" continue } @@ -290,7 +287,6 @@ with_test_prefix "address" { clean_restart $binfile if {![runto_main]} { - untested "could not run to main" continue } @@ -309,7 +305,6 @@ with_test_prefix "check alignment" { clean_restart $binfile if {![runto_main]} { - untested "could not run to main" continue } |