[gdb/testsuite] Handle missing .note.GNU-stack

On openSUSE Tumbleweed I run into this for the dwarf assembly test-cases, and
some hardcoded assembly test-cases:
...
 Running gdb.dwarf2/fission-absolute-dwo.exp ...
 gdb compile failed, ld: warning: fission-absolute-dwo.o: \
   missing .note.GNU-stack section implies executable stack
 ld: NOTE: This behaviour is deprecated and will be removed in a future \
   version of the linker

                 === gdb Summary ===

 # of untested testcases         1
...

Fix the dwarf assembly test-cases by adding the missing .note.GNU-stack in
proc Dwarf::assemble.

Fix the hard-coded test-cases using this command:
...
$ for f in $(find gdb/testsuite/gdb.* -name *.S); do
    if ! grep -q note.GNU-stack $f; then
      echo -e "\t.section\t.note.GNU-stack,\"\",@progbits" >> $f;
    fi;
  done
...

Likewise for .s files, and gdb/testsuite/lib/my-syscalls.S.

The idiom for arm seems to be to use %progbits instead, see commit 9a5911c08be
("gdb/testsuite/gdb.dwarf2: Replace @ with % for ARM compatability"), so
hand-edit gdb/testsuite/gdb.arch/arm-disp-step.S to use %progbits instead.

Note that dwarf assembly testcases use %progbits as decided by proc _section.

Tested on x86_64-linux.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29674

19 files changed, 19 insertions, 0 deletions

diff --git a/gdb/testsuite/gdb.disasm/am33.s b/gdb/testsuite/gdb.disasm/am33.s
index a686cef..e699bcf 100644
--- a/gdb/testsuite/gdb.disasm/am33.s
+++ b/gdb/testsuite/gdb.disasm/am33.s
@@ -522,3 +522,4 @@ dsp_autoincrement_tests:
 	mov_leq (r1+,4),r2
 	mov_lne (r1+,4),r2
 	mov_lra (r1+,4),r2
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/h8300s.s b/gdb/testsuite/gdb.disasm/h8300s.s
index 6510d40..0fd8656 100644
--- a/gdb/testsuite/gdb.disasm/h8300s.s
+++ b/gdb/testsuite/gdb.disasm/h8300s.s
@@ -354,3 +354,4 @@ system_control_tests:
 block_data_transfer_tests:
 	eepmov.b
 	eepmov.w
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/hppa.s b/gdb/testsuite/gdb.disasm/hppa.s
index 593d8bf..12ace7d 100644
--- a/gdb/testsuite/gdb.disasm/hppa.s
+++ b/gdb/testsuite/gdb.disasm/hppa.s
@@ -1736,3 +1736,4 @@ fmemLRbug_tests_4
 	bv,n 0(%r2)
 	.EXIT
 	.PROCEND
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/mn10200.s b/gdb/testsuite/gdb.disasm/mn10200.s
index 32357b0..c48dd64 100644
--- a/gdb/testsuite/gdb.disasm/mn10200.s
+++ b/gdb/testsuite/gdb.disasm/mn10200.s
@@ -215,3 +215,4 @@ sub_tests:
 	sub 32767,a2
 	sub 131071,a2
 	subc d1,d2
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/mn10300.s b/gdb/testsuite/gdb.disasm/mn10300.s
index 3ad6c95..e7ab6e4 100644
--- a/gdb/testsuite/gdb.disasm/mn10300.s
+++ b/gdb/testsuite/gdb.disasm/mn10300.s
@@ -298,3 +298,4 @@ sub_tests:
 	sub 131071,a1
 	subc d1,d2
 
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/sh3.s b/gdb/testsuite/gdb.disasm/sh3.s
index e5969f5..ab70da3 100644
--- a/gdb/testsuite/gdb.disasm/sh3.s
+++ b/gdb/testsuite/gdb.disasm/sh3.s
@@ -52,3 +52,4 @@ _fp_misc_tests:
 	sts	fpscr,r3
 	sts.l	fpscr,@-r3
 
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t01_mov.s b/gdb/testsuite/gdb.disasm/t01_mov.s
index 6848304..d79d8aa 100644
--- a/gdb/testsuite/gdb.disasm/t01_mov.s
+++ b/gdb/testsuite/gdb.disasm/t01_mov.s
@@ -1105,3 +1105,4 @@ label:
 
 	.end
 
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t02_mova.s b/gdb/testsuite/gdb.disasm/t02_mova.s
index 4615bcc..b16da02 100644
--- a/gdb/testsuite/gdb.disasm/t02_mova.s
+++ b/gdb/testsuite/gdb.disasm/t02_mova.s
@@ -236,3 +236,4 @@ _start:
     mova/l.l @(0x12345678:32,@0x9ABCDEF0:32.w),er1         ;015F48D99ABCDEF012345678
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t03_add.s b/gdb/testsuite/gdb.disasm/t03_add.s
index 2b83247..024ae61 100644
--- a/gdb/testsuite/gdb.disasm/t03_add.s
+++ b/gdb/testsuite/gdb.disasm/t03_add.s
@@ -976,3 +976,4 @@ _start:
     add.l @0x12345678:32,@0x9abcdef0:32                    ;01046b2c1234567848109abcdef0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t04_sub.s b/gdb/testsuite/gdb.disasm/t04_sub.s
index d851760..066f0236 100644
--- a/gdb/testsuite/gdb.disasm/t04_sub.s
+++ b/gdb/testsuite/gdb.disasm/t04_sub.s
@@ -975,3 +975,4 @@ _start:
     sub.l @0x12345678:32,@0x9abcdef0:32                    ;01046b2c1234567848309abcdef0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t05_cmp.s b/gdb/testsuite/gdb.disasm/t05_cmp.s
index ee034f0..8d5b393 100644
--- a/gdb/testsuite/gdb.disasm/t05_cmp.s
+++ b/gdb/testsuite/gdb.disasm/t05_cmp.s
@@ -919,3 +919,4 @@ _start:
     cmp.l @0x12345678:32,@0x9abcdef0:32                    ;01046b2c1234567848209abcdef0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t06_ari2.s b/gdb/testsuite/gdb.disasm/t06_ari2.s
index 75a9195..dd0e314 100644
--- a/gdb/testsuite/gdb.disasm/t06_ari2.s
+++ b/gdb/testsuite/gdb.disasm/t06_ari2.s
@@ -186,3 +186,4 @@ _start:
     divs.l er3,er1            ;01d25331
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t07_ari3.s b/gdb/testsuite/gdb.disasm/t07_ari3.s
index 6ad7128..a4afef4 100644
--- a/gdb/testsuite/gdb.disasm/t07_ari3.s
+++ b/gdb/testsuite/gdb.disasm/t07_ari3.s
@@ -171,3 +171,4 @@ _start:
     exts.l #2,@0x12345678:32         ;01046b281234567817e0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t08_or.s b/gdb/testsuite/gdb.disasm/t08_or.s
index da4e216..0fa35ab 100644
--- a/gdb/testsuite/gdb.disasm/t08_or.s
+++ b/gdb/testsuite/gdb.disasm/t08_or.s
@@ -970,3 +970,4 @@ _start:
     or.l @0x12345678:32,@0x9abcdef0:32                    ;01046b2c1234567848409abcdef0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t09_xor.s b/gdb/testsuite/gdb.disasm/t09_xor.s
index ccd479c..05e7510 100644
--- a/gdb/testsuite/gdb.disasm/t09_xor.s
+++ b/gdb/testsuite/gdb.disasm/t09_xor.s
@@ -970,3 +970,4 @@ _start:
     xor.l @0x12345678:32,@0x9abcdef0:32                    ;01046b2c1234567848509abcdef0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t10_and.s b/gdb/testsuite/gdb.disasm/t10_and.s
index 0459c10..457b67e 100644
--- a/gdb/testsuite/gdb.disasm/t10_and.s
+++ b/gdb/testsuite/gdb.disasm/t10_and.s
@@ -970,3 +970,4 @@ _start:
     and.l @0x12345678:32,@0x9abcdef0:32                    ;01046b2c1234567848609abcdef0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t11_logs.s b/gdb/testsuite/gdb.disasm/t11_logs.s
index 4768591..228a674 100644
--- a/gdb/testsuite/gdb.disasm/t11_logs.s
+++ b/gdb/testsuite/gdb.disasm/t11_logs.s
@@ -1175,3 +1175,4 @@ _start:
     rotr.l #2,@0x12345678:32         ;01046b281234567813f0
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t12_bit.s b/gdb/testsuite/gdb.disasm/t12_bit.s
index 4c45b2a..2664a75 100644
--- a/gdb/testsuite/gdb.disasm/t12_bit.s
+++ b/gdb/testsuite/gdb.disasm/t12_bit.s
@@ -174,3 +174,4 @@ _start:
     bfst r3h,#0x34:8,@0x12345678:32           ;6a3812345678f334
 
 	.end
+	.section	.note.GNU-stack,"",@progbits
diff --git a/gdb/testsuite/gdb.disasm/t13_otr.s b/gdb/testsuite/gdb.disasm/t13_otr.s
index 69db411..812cbcf 100644
--- a/gdb/testsuite/gdb.disasm/t13_otr.s
+++ b/gdb/testsuite/gdb.disasm/t13_otr.s
@@ -157,3 +157,4 @@ _start:
     nop                        ;0000
 
 	.end
+	.section	.note.GNU-stack,"",@progbits