diff options
| author | Yao Qi <yao@codesourcery.com> | 2014-09-29 20:47:30 +0800 |
|---|---|---|
| committer | Yao Qi <yao@codesourcery.com> | 2014-10-20 13:34:28 +0800 |
| commit | acbdb7f355f9dfa851dcff3154944a0d96771b0e (patch) | |
| tree | e96ad56f9b500542b0deb11731d858da901ee956 /gdb/testsuite/gdb.base | |
| parent | c6ecbe44d87c71dc97f5d305c47cc3f7d4510e57 (diff) | |
| download | gdb-acbdb7f355f9dfa851dcff3154944a0d96771b0e.zip gdb-acbdb7f355f9dfa851dcff3154944a0d96771b0e.tar.gz gdb-acbdb7f355f9dfa851dcff3154944a0d96771b0e.tar.bz2 | |
Don't remove files copied to host
Nowadays, if we do in-tree build and run tests sequentially, some source
files are removed, due to the following pattern:
set pi_txt [gdb_remote_download host ${srcdir}/${subdir}/pi.txt]
remote_exec host "rm -f $pi_txt"
If testing is run sequentially, file ${srcdir}/${subdir}/pi.txt is
copied to ${objdir}/${subdir}/pi.txt. However, ${objdir} is ${srcdir}
in the in-tree build/test, so the file is coped to itself, as a nop.
As a result, the file in source is removed at the end of test.
This patch fixes this problem by not removing files copied to host in
each test. This patch also addresses the question we've had that why
don't we keep files copied to host because they are needed to reproduce
certain fails.
gdb/testsuite:
2014-10-20 Yao Qi <yao@codesourcery.com>
* gdb.base/checkpoint.exp: Don't remove file copied on host.
* gdb.base/step-line.exp: Likewise.
* gdb.dwarf2/dw2-anonymous-func.exp: Likewise.
* gdb.dwarf2/dw2-basic.exp: Likewise.
* gdb.dwarf2/dw2-compressed.exp: Likewise.
* gdb.dwarf2/dw2-filename.exp: Likewise.
* gdb.dwarf2/dw2-intercu.exp: Likewise.
* gdb.dwarf2/dw2-intermix.exp: Likewise.
* gdb.dwarf2/dw2-producer.exp: Likewise.
* gdb.dwarf2/mac-fileno.exp: Likewise.
* gdb.python/py-frame-args.exp: Likewise.
* gdb.python/py-framefilter.exp: Likewise.
* gdb.python/py-mi.exp: Likewise.
* gdb.python/py-objfile-script.exp: Likewise
* gdb.python/py-pp-integral.exp: Likewise.
* gdb.python/py-pp-re-notag.exp: Likewise.
* gdb.python/py-prettyprint.exp: Likewise.
* gdb.python/py-section-script.exp: Likewise.
* gdb.python/py-typeprint.exp: Likewise.
* gdb.python/py-xmethods.exp: Likewise.
* gdb.stabs/weird.exp: Likewise.
* gdb.xml/tdesc-regs.exp: Likewise.
Diffstat (limited to 'gdb/testsuite/gdb.base')
| -rw-r--r-- | gdb/testsuite/gdb.base/checkpoint.exp | 2 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/step-line.exp | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp index b5ed1d3..2de2439 100644 --- a/gdb/testsuite/gdb.base/checkpoint.exp +++ b/gdb/testsuite/gdb.base/checkpoint.exp @@ -371,5 +371,3 @@ verbose "Timeout now $timeout sec." # # Finished: cleanup # - -remote_exec host "rm -f $pi_txt" diff --git a/gdb/testsuite/gdb.base/step-line.exp b/gdb/testsuite/gdb.base/step-line.exp index 94799f8..7f51565 100644 --- a/gdb/testsuite/gdb.base/step-line.exp +++ b/gdb/testsuite/gdb.base/step-line.exp @@ -82,6 +82,4 @@ gdb_test "next" \ ".*RETURN \\(j\\);.*" \ "next over dummy 10" -remote_file host delete ${remote_linefile} - return 0 |