diff options
author | Joel Brobecker <brobecker@gnat.com> | 2011-10-02 02:13:13 +0000 |
---|---|---|
committer | Joel Brobecker <brobecker@gnat.com> | 2011-10-02 02:13:13 +0000 |
commit | dd11a36cfed586c986916fa8ae3a087af6408fb3 (patch) | |
tree | a6238eb102c351626e48880c889e5d44b2835a96 /gdb/testsuite/gdb.base/save-bp.c | |
parent | 2fed52b14d501f43023fe5d167ee4c7b4cf9e0d6 (diff) | |
download | gdb-dd11a36cfed586c986916fa8ae3a087af6408fb3.zip gdb-dd11a36cfed586c986916fa8ae3a087af6408fb3.tar.gz gdb-dd11a36cfed586c986916fa8ae3a087af6408fb3.tar.bz2 |
thread-specific breakpoints not saved properly by save-breakpoint
Initially, I noticed that the save command was often missing
new lines in the file that it generated. For instance, consider:
% gdb save-bp
(gdb) b break_me
(gdb) b save-bp.c:27
(gdb) save breakpoints bps
The contents of the bps file would be:
% cat bps
break break_mebreak save-bp.c:27
Looking further into the problem, I realized that the missing newlines
are just a consequence of a missing call to print_recreate_thread.
After having generated the breakpoint location in the break command,
we cannot put a new line until we have looked at whether we need to
add a 'thread NUM' argument.
gdb/ChangeLog:
* breakpoint.c (bkpt_print_recreate): Add call to
print_recreate_thread.
gdb/testsuite/ChangeLog:
* gdb.base/save-bp.exp, gdb.base/save-bp.c: New files.
Diffstat (limited to 'gdb/testsuite/gdb.base/save-bp.c')
-rw-r--r-- | gdb/testsuite/gdb.base/save-bp.c | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.base/save-bp.c b/gdb/testsuite/gdb.base/save-bp.c new file mode 100644 index 0000000..3469124 --- /dev/null +++ b/gdb/testsuite/gdb.base/save-bp.c @@ -0,0 +1,36 @@ +/* Copyright 2011 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +void +break_me (void) +{ +} + +int +main (void) +{ + int i; + break_me (); /* BREAK HERE. */ + break_me (); /* Try a thread-specific breakpoint. */ + + for (i = 0; i < 5; i++) + break_me (); /* Try a condition-specific breakpoint. */ + + break_me (); /* Finally, try a breakpoint with commands. */ + return 0; +} + |