diff options
author | Tom Tromey <tromey@adacore.com> | 2019-04-29 12:11:52 -0600 |
---|---|---|
committer | Tom Tromey <tromey@adacore.com> | 2019-05-08 10:15:51 -0600 |
commit | 844333e24966817fe4d622494a75c8ae0acdb91f (patch) | |
tree | 2343113e735702b3eea6443eb81bb69bdb707fd4 /gdb/testsuite/ChangeLog | |
parent | 988915ee7b880ff059f849893b71118d9bd2c4fc (diff) | |
download | gdb-844333e24966817fe4d622494a75c8ae0acdb91f.zip gdb-844333e24966817fe4d622494a75c8ae0acdb91f.tar.gz gdb-844333e24966817fe4d622494a75c8ae0acdb91f.tar.bz2 |
Fix ptype/o comment formatting
I noticed that ptype/o will print:
/* 3: 3 | 1 */ signed char a4 : 2;
/* XXX 3-bit hole */
That is, "*/" at the end of the "hole" message does not line up with
the other comment ends. I thought it would be a bit nicer if this did
line up, so I fixed it. Then, to my surprise, I found that I could
not make ptype-offsets.exp fail.
I still am not sure why it doesn't fail, but changing the tests to use
string_to_regexp and changing the quoting helped. This in turn showed
that some of the existing test cases were wrong, so I've also updated
them here.
gdb/ChangeLog
2019-05-08 Tom Tromey <tromey@adacore.com>
* typeprint.c (print_offset_data::maybe_print_hole): Add extra
padding at end of comment.
gdb/testsuite/ChangeLog
2019-05-08 Tom Tromey <tromey@adacore.com>
* gdb.base/ptype-offsets.exp: Use string_to_regexp. Fix test
cases.
* gdb.base/ptype-offsets.cc (struct abc) <my_int_type>: Now
"short".
Diffstat (limited to 'gdb/testsuite/ChangeLog')
-rw-r--r-- | gdb/testsuite/ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index cfa10e3..eb1110e 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,12 @@ 2019-05-08 Tom Tromey <tromey@adacore.com> + * gdb.base/ptype-offsets.exp: Use string_to_regexp. Fix test + cases. + * gdb.base/ptype-offsets.cc (struct abc) <my_int_type>: Now + "short". + +2019-05-08 Tom Tromey <tromey@adacore.com> + * gdb.ada/vla.exp: New file. * gdb.ada/vla/vla.adb: New file. |