diff options
| author | Pedro Alves <palves@redhat.com> | 2020-05-19 18:36:24 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2020-05-19 18:36:51 +0100 |
| commit | 4111f652f955028e8219fad2d60af1fd22aa29ee (patch) | |
| tree | d50f5be0ada132550b4096402f2afbf560f17430 /gdb/target.h | |
| parent | ad80db5b9f7c95105c78d3ab439678184d1b7177 (diff) | |
| download | gdb-4111f652f955028e8219fad2d60af1fd22aa29ee.zip gdb-4111f652f955028e8219fad2d60af1fd22aa29ee.tar.gz gdb-4111f652f955028e8219fad2d60af1fd22aa29ee.tar.bz2 | |
Eliminate target_fileio_open_warn_if_slow
This basically makes target_fileio_open_1 extern, renamed to
target_fileio_open, and eliminates the current
target_fileio_open_warn_if_slow and target_fileio_open.
A following parameter will want to change gdb_bfd_iovec_fileio_open,
the only caller of target_fileio_open_warn_if_slow, to pass down
"warn_if_slow" true/false from the caller, instead of hardcoding
"warn_if_slow" true.
gdb/ChangeLog:
2020-05-19 Pedro Alves <palves@redhat.com>
* gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
* target.c (target_fileio_open_1): Rename to target_fileio_open
and make extern. Use bool.
(target_fileio_open, target_fileio_open_warn_if_slow): Delete.
(target_fileio_read_alloc_1): Adjust.
* target.h (target_fileio_open): Add 'warn_if_slow' parameter.
(target_fileio_open_warn_if_slow): Delete declaration.
Diffstat (limited to 'gdb/target.h')
| -rw-r--r-- | gdb/target.h | 20 |
1 files changed, 7 insertions, 13 deletions
diff --git a/gdb/target.h b/gdb/target.h index 9a1dd80..37bfb29 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -2135,21 +2135,15 @@ extern int target_search_memory (CORE_ADDR start_addr, current_top_target ()->filesystem_is_local () /* Open FILENAME on the target, in the filesystem as seen by INF, - using FLAGS and MODE. If INF is NULL, use the filesystem seen - by the debugger (GDB or, for remote targets, the remote stub). - Return a target file descriptor, or -1 if an error occurs (and - set *TARGET_ERRNO). */ + using FLAGS and MODE. If INF is NULL, use the filesystem seen by + the debugger (GDB or, for remote targets, the remote stub). Return + a target file descriptor, or -1 if an error occurs (and set + *TARGET_ERRNO). If WARN_IF_SLOW is true, print a warning message + if the file is being accessed over a link that may be slow. */ extern int target_fileio_open (struct inferior *inf, const char *filename, int flags, - int mode, int *target_errno); - -/* Like target_fileio_open, but print a warning message if the - file is being accessed over a link that may be slow. */ -extern int target_fileio_open_warn_if_slow (struct inferior *inf, - const char *filename, - int flags, - int mode, - int *target_errno); + int mode, bool warn_if_slow, + int *target_errno); /* Write up to LEN bytes from WRITE_BUF to FD on the target. Return the number of bytes written, or -1 if an error occurs |