diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-03-23 09:50:32 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-03-23 09:50:32 -0400 |
| commit | fadf6add3028d477457c809f60f07643964d7fd2 (patch) | |
| tree | 6892c92baa1dc60e5e238e9bee69c0fd2fe732cc /gdb/target.h | |
| parent | 70e958370c8f4dc3222b658a725571d8d2f5f98a (diff) | |
| download | gdb-fadf6add3028d477457c809f60f07643964d7fd2.zip gdb-fadf6add3028d477457c809f60f07643964d7fd2.tar.gz gdb-fadf6add3028d477457c809f60f07643964d7fd2.tar.bz2 | |
gdb: remove unpush_target free function
unpush_target unpushes the passed-in target from the current inferior's
target stack. Calling it is therefore an implicit dependency on the
current global inferior. Remove that function and make the callers use
the inferior::unpush_target method directly. This sometimes allows
using the inferior from the context rather than the global current
inferior.
target_unpusher::operator() now needs to be implemented in target.c,
otherwise target.h and inferior.h both need to include each other, and
that wouldn't work.
gdb/ChangeLog:
* target.h (unpush_target): Remove, update all callers
to use `inferior::unpush_target` instead.
(struct target_unpusher) <operator()>: Just declare.
* target.c (unpush_target): Remove.
(target_unpusher::operator()): New.
Change-Id: Ia5172dfb3f373e0a75b991885b50322ca2142a8c
Diffstat (limited to 'gdb/target.h')
| -rw-r--r-- | gdb/target.h | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/gdb/target.h b/gdb/target.h index ee93c5c..3a64094 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -2390,16 +2390,11 @@ extern void push_target (struct target_ops *); /* An overload that deletes the target on failure. */ extern void push_target (target_ops_up &&); -extern int unpush_target (struct target_ops *); - /* A unique_ptr helper to unpush a target. */ struct target_unpusher { - void operator() (struct target_ops *ops) const - { - unpush_target (ops); - } + void operator() (struct target_ops *ops) const; }; /* A unique_ptr that unpushes a target on destruction. */ |