diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2015-11-26 09:49:03 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2015-11-26 09:49:03 -0500 |
| commit | 73ede76585a987a07fbd67a7474b193e4ca05517 (patch) | |
| tree | de94daac963b3cb4d15f84701db204ff6e42d69b /gdb/target.h | |
| parent | 46a3515b49ce30315e2b621525b29cd8263aed15 (diff) | |
| download | gdb-73ede76585a987a07fbd67a7474b193e4ca05517.zip gdb-73ede76585a987a07fbd67a7474b193e4ca05517.tar.gz gdb-73ede76585a987a07fbd67a7474b193e4ca05517.tar.bz2 | |
Constify thread name return path
Since this code path returns a string owned by the target (we don't know how
it's allocated, could be a static read-only string), it's safer if we return
a constant string. If, for some reasons, the caller wishes to modify the
string, it should make itself a copy.
gdb/ChangeLog:
* linux-nat.c (linux_nat_thread_name): Constify return value.
* target.h (struct target_ops) <to_thread_name>: Likewise.
(target_thread_name): Likewise.
* target.c (target_thread_name): Likewise.
* target-delegates.c (debug_thread_name): Regenerate.
* python/py-infthread.c (thpy_get_name): Constify local variables.
* thread.c (print_thread_info): Likewise.
(thread_find_command): Likewise.
Diffstat (limited to 'gdb/target.h')
| -rw-r--r-- | gdb/target.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/target.h b/gdb/target.h index e80bee5..ac28a41 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -639,7 +639,7 @@ struct target_ops TARGET_DEFAULT_FUNC (default_pid_to_str); char *(*to_extra_thread_info) (struct target_ops *, struct thread_info *) TARGET_DEFAULT_RETURN (NULL); - char *(*to_thread_name) (struct target_ops *, struct thread_info *) + const char *(*to_thread_name) (struct target_ops *, struct thread_info *) TARGET_DEFAULT_RETURN (NULL); void (*to_stop) (struct target_ops *, ptid_t) TARGET_DEFAULT_IGNORE (); @@ -1823,7 +1823,7 @@ extern char *normal_pid_to_str (ptid_t ptid); /* Return the thread's name. A NULL result means that the target could not determine this thread's name. */ -extern char *target_thread_name (struct thread_info *); +extern const char *target_thread_name (struct thread_info *); /* Attempts to find the pathname of the executable file that was run to create a specified process. |