diff options
| author | Pedro Alves <palves@redhat.com> | 2013-12-02 10:12:24 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-12-02 11:10:20 +0000 |
| commit | aee4bf85057de1905f5bfaad2a4be0295905d7fb (patch) | |
| tree | 4d38c1d340bfc9824fd0cf22d42166dc04402446 /gdb/target.c | |
| parent | 840207d8ee5249c11463baaf5fb37c44595c4f00 (diff) | |
| download | gdb-aee4bf85057de1905f5bfaad2a4be0295905d7fb.zip gdb-aee4bf85057de1905f5bfaad2a4be0295905d7fb.tar.gz gdb-aee4bf85057de1905f5bfaad2a4be0295905d7fb.tar.bz2 | |
Add new target_read_raw_memory function, and consolidate comments.
Tested on x86_64 Fedora 17.
gdb/
2013-12-02 Pedro Alves <palves@redhat.com>
* dcache.c (dcache_read_line): Use target_read_raw_memory.
* target.c (target_read_raw_memory): New function.
(target_read_stack, target_write_memory, target_write_raw_memory):
Update comment.
(target_read_code): Add comment.
* target.h (target_read_raw_memory): Declare.
Diffstat (limited to 'gdb/target.c')
| -rw-r--r-- | gdb/target.c | 34 |
1 files changed, 24 insertions, 10 deletions
diff --git a/gdb/target.c b/gdb/target.c index 6c72e70..85b5037 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -1791,16 +1791,30 @@ target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len) return TARGET_XFER_E_IO; } +/* Like target_read_memory, but specify explicitly that this is a read + from the target's raw memory. That is, this read bypasses the + dcache, breakpoint shadowing, etc. */ + +int +target_read_raw_memory (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len) +{ + /* See comment in target_read_memory about why the request starts at + current_target.beneath. */ + if (target_read (current_target.beneath, TARGET_OBJECT_RAW_MEMORY, NULL, + myaddr, memaddr, len) == len) + return 0; + else + return TARGET_XFER_E_IO; +} + /* Like target_read_memory, but specify explicitly that this is a read from the target's stack. This may trigger different cache behavior. */ int target_read_stack (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len) { - /* Dispatch to the topmost target, not the flattened current_target. - Memory accesses check target->to_has_(all_)memory, and the - flattened target doesn't inherit those. */ - + /* See comment in target_read_memory about why the request starts at + current_target.beneath. */ if (target_read (current_target.beneath, TARGET_OBJECT_STACK_MEMORY, NULL, myaddr, memaddr, len) == len) return 0; @@ -1814,6 +1828,8 @@ target_read_stack (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len) int target_read_code (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len) { + /* See comment in target_read_memory about why the request starts at + current_target.beneath. */ if (target_read (current_target.beneath, TARGET_OBJECT_CODE_MEMORY, NULL, myaddr, memaddr, len) == len) return 0; @@ -1830,9 +1846,8 @@ target_read_code (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len) int target_write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, ssize_t len) { - /* Dispatch to the topmost target, not the flattened current_target. - Memory accesses check target->to_has_(all_)memory, and the - flattened target doesn't inherit those. */ + /* See comment in target_read_memory about why the request starts at + current_target.beneath. */ if (target_write (current_target.beneath, TARGET_OBJECT_MEMORY, NULL, myaddr, memaddr, len) == len) return 0; @@ -1849,9 +1864,8 @@ target_write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, ssize_t len) int target_write_raw_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, ssize_t len) { - /* Dispatch to the topmost target, not the flattened current_target. - Memory accesses check target->to_has_(all_)memory, and the - flattened target doesn't inherit those. */ + /* See comment in target_read_memory about why the request starts at + current_target.beneath. */ if (target_write (current_target.beneath, TARGET_OBJECT_RAW_MEMORY, NULL, myaddr, memaddr, len) == len) return 0; |