aboutsummaryrefslogtreecommitdiff
path: root/gdb/target-debug.h
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2019-01-24 18:25:06 +0000
committerPedro Alves <palves@redhat.com>2019-01-24 18:25:06 +0000
commitadc6a863a9c6c828425d63b12d553f0e8f21e350 (patch)
tree707b67c07bca0de636702016728f8eb8dd8f49a5 /gdb/target-debug.h
parent3046d67a0e29686ec18abd719660969c97973063 (diff)
downloadgdb-adc6a863a9c6c828425d63b12d553f0e8f21e350.zip
gdb-adc6a863a9c6c828425d63b12d553f0e8f21e350.tar.gz
gdb-adc6a863a9c6c828425d63b12d553f0e8f21e350.tar.bz2
target_pass_signals/target_program_signals: Use gdb::array_view
This replaces the pointer and length parameters of target_pass_signals and target_program_signals with a gdb::array_view parameter, and fixes the fallout. In infrun.c, the signal_stop, signal_print, signal_program, signal_catch, signal_pass globals are currently pointers to heap-allocated memory. I see no point in that, so I converted them to arrays. This allows simplifying the calls to target_pass_signals/target_program_signals, since we can pass the array directly, which can implicitly convert to gdb::array_view. gdb/ChangeLog: 2019-01-24 Pedro Alves <palves@redhat.com> * infrun.c (signal_stop, signal_print, signal_program) (signal_catch, signal_pass): Now arrays instead of pointers. (update_signals_program_target, do_target_resume) (signal_catch_update, handle_command, _initialize_infrun): Adjust. * linux-nat.c (linux_nat_target::pass_signals) (linux_nat_target::create_inferior, linux_nat_target::attach): Adjust. * linux-nat.h (linux_nat_target::pass_signals): Adjust. * nto-procfs.c (nto_procfs_target::pass_signals): Adjust. * procfs.c (procfs_target::pass_signals): Adjust. * record-full.c (record_full_target::resume): Adjust. * remote.c (remote_target::pass_signals) (remote_target::program_signals): Adjust. * target-debug.h (target_debug_print_signals): Now takes a gdb::array_view as parameter. Adjust. * target.h (target_ops) <pass_signals, program_signals>: Replace pointer and length parameters with gdb::array_view. (target_pass_signals, target_program_signals): Likewise. * target-delegates.c: Regenerate.
Diffstat (limited to 'gdb/target-debug.h')
-rw-r--r--gdb/target-debug.h20
1 files changed, 8 insertions, 12 deletions
diff --git a/gdb/target-debug.h b/gdb/target-debug.h
index d51754a..d9f7d46 100644
--- a/gdb/target-debug.h
+++ b/gdb/target-debug.h
@@ -209,20 +209,16 @@ target_debug_print_options (int options)
}
static void
-target_debug_print_signals (const unsigned char *sigs)
+target_debug_print_signals (gdb::array_view<const unsigned char> sigs)
{
fputs_unfiltered ("{", gdb_stdlog);
- if (sigs != NULL)
- {
- int i;
-
- for (i = 0; i < GDB_SIGNAL_LAST; i++)
- if (sigs[i])
- {
- fprintf_unfiltered (gdb_stdlog, " %s",
- gdb_signal_to_name ((enum gdb_signal) i));
- }
- }
+
+ for (size_t i = 0; i < sigs.size (); i++)
+ if (sigs[i] != 0)
+ {
+ fprintf_unfiltered (gdb_stdlog, " %s",
+ gdb_signal_to_name ((enum gdb_signal) i));
+ }
fputs_unfiltered (" }", gdb_stdlog);
}