diff options
| author | Yao Qi <yao@codesourcery.com> | 2013-11-20 16:21:47 +0800 |
|---|---|---|
| committer | Yao Qi <yao@codesourcery.com> | 2013-11-24 14:56:48 +0800 |
| commit | 0fb14d8ffde0940e0b55d529c50a5d424b763b13 (patch) | |
| tree | 94aa270a61fb410036e8b771ce2dc4712a2b288a /gdb/target-dcache.h | |
| parent | 22825df749cf79e849f6df35a6d3d0ae4e5a277e (diff) | |
| download | gdb-0fb14d8ffde0940e0b55d529c50a5d424b763b13.zip gdb-0fb14d8ffde0940e0b55d529c50a5d424b763b13.tar.gz gdb-0fb14d8ffde0940e0b55d529c50a5d424b763b13.tar.bz2 | |
Renaming in target-dcache.c
Hi,
This patch does some renamings on "stack-cache" related functions and
variables.
In the review to "code cache" series v2, we have some discussions on the
name of predicate function 'stack_cache_enabled', and have some options,
1 keep it unchanged, as it is already a predicate clearly,
2 rename it to stack_cache_enabled_p,
3 rename it to enable_stack_cache_p,
I choose #2, because 'stack_cache_enabled' is a predicate, but
it's better to add "_p" suffix to stress this. There are some other
similar patterns used in GDB source, such as unop_user_defined_p
and agent_loaded_p.
Then, I have to rename variable stack_cache_enabled_p to something
else. The option is "stack-cache", so I'd like to name the variable
associated with this command as "stack_cache". Similarly, the commands
associated with this command should be renamed to "set_stack_cache"
and "show_stack_cache" respectively.
gdb:
2013-11-24 Yao Qi <yao@codesourcery.com>
* target-dcache.c (stack_cache_enabled_p_1): Rename to ...
(stack_cache_enabled_1): ... this. New variable.
(stack_cache_enabled_p): Rename to ...
(stack_cache_enabled): ... this. New variable.
(set_stack_cache_enabled_p): Rename to ...
(set_stack_cache): ... this. Update caller.
(show_stack_cache_enabled_p): Rename to ...
(show_stack_cache): ... this. Update caller.
(stack_cache_enabled): Rename to ...
(stack_cache_enabled_p): ... this. Update caller.
(_initialize_target_dcache): Replace "data cache" with
"target memory cache".
* target-dcache.h (stack_cache_enabled): Remove declaration.
(stack_cache_enabled_p): Add declaration.
Diffstat (limited to 'gdb/target-dcache.h')
| -rw-r--r-- | gdb/target-dcache.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/target-dcache.h b/gdb/target-dcache.h index a5e1556..3200dd9 100644 --- a/gdb/target-dcache.h +++ b/gdb/target-dcache.h @@ -28,6 +28,6 @@ extern DCACHE *target_dcache_get_or_init (void); extern int target_dcache_init_p (void); -extern int stack_cache_enabled (void); +extern int stack_cache_enabled_p (void); #endif /* TARGET_DCACHE_H */ |