diff options
| author | Tom Tromey <tom@tromey.com> | 2016-06-03 14:11:08 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2016-07-26 13:43:27 -0600 |
| commit | 0b31a4bcec2efec9bc8ca40deb61123c52690a2e (patch) | |
| tree | 174c97fc33b15c671836a0d5f8744b8981dbb7bf /gdb/symtab.c | |
| parent | 8484fb75874eb9ef35710ac6579433f062ddba18 (diff) | |
| download | gdb-0b31a4bcec2efec9bc8ca40deb61123c52690a2e.zip gdb-0b31a4bcec2efec9bc8ca40deb61123c52690a2e.tar.gz gdb-0b31a4bcec2efec9bc8ca40deb61123c52690a2e.tar.bz2 | |
PR python/20190 - compute TLS symbol without a frame
PR python/20190 arose from an exception I noticed when trying to use
the Python unwinder for Spider Monkey in Firefox.
The problem is that the unwinder wants to examine the value of a
thread-local variable. However, sympy_value rejects this because
symbol_read_needs_frame returns true for a TLS variable.
This problem arose once before, though in a different context:
https://sourceware.org/bugzilla/show_bug.cgi?id=11803
At the time Pedro and Daniel pointed out a simpler way to fix that bug
(see links in 20190 if you are interested); but for this new bug I
couldn't think of a similar fix and ended up implementing Daniel's
other suggestion:
https://sourceware.org/ml/gdb-patches/2010-07/msg00393.html
That is, this patch makes it possible to detect whether a symbol needs
a specific frame, or whether it just needs the inferior to have
registers.
Built and regtested on x86-64 Fedora 24.
2016-07-26 Tom Tromey <tom@tromey.com>
* symtab.c (register_symbol_computed_impl): Update.
PR python/20190:
* value.h (symbol_read_needs): Declare.
(symbol_read_needs_frame): Add comment.
* symtab.h (struct symbol_computed_ops) <read_variable>: Update
comment.
<get_symbol_read_needs>: Rename. Change return type.
* findvar.c (symbol_read_needs): New function.
(symbol_read_needs_frame): Rewrite.
(default_read_var_value): Use symbol_read_needs.
* dwarf2loc.c (struct symbol_needs_baton): Rename.
<needs>: Renamed from needs_frame. Changed type.
(needs_frame_read_addr_from_reg, symbol_needs_get_reg_value)
(symbol_needs_read_mem, symbol_needs_frame_base)
(symbol_needs_frame_cfa, symbol_needs_tls_address)
(symbol_needs_dwarf_call): Rename.
(needs_dwarf_reg_entry_value): Update.
(symbol_needs_ctx_funcs, dwarf2_loc_desc_get_symbol_read_needs):
Rename and update.
(locexpr_get_symbol_read_needs, loclist_symbol_needs): Likewise.
(dwarf2_locexpr_funcs, dwarf2_loclist_funcs): Update.
* defs.h (enum symbol_needs_kind): New.
2016-07-26 Tom Tromey <tom@tromey.com>
PR python/20190:
* gdb.threads/tls.exp (check_thread_local): Add python symbol
test.
Diffstat (limited to 'gdb/symtab.c')
| -rw-r--r-- | gdb/symtab.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/symtab.c b/gdb/symtab.c index 5c4305d..e776a0c 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -6092,7 +6092,7 @@ register_symbol_computed_impl (enum address_class aclass, gdb_assert (ops != NULL); gdb_assert (ops->tracepoint_var_ref != NULL); gdb_assert (ops->describe_location != NULL); - gdb_assert (ops->read_needs_frame != NULL); + gdb_assert (ops->get_symbol_read_needs != NULL); gdb_assert (ops->read_variable != NULL); return result; |