aboutsummaryrefslogtreecommitdiff
path: root/gdb/symtab.c
diff options
context:
space:
mode:
authorChristian Biesinger <cbiesinger@google.com>2019-07-11 13:35:13 -0500
committerChristian Biesinger <cbiesinger@google.com>2019-07-21 22:23:12 -0500
commitc32e6a04f42b8e4a1392ee4b87d040c06b917ef5 (patch)
treeb556abc4d0b27a5fb9bbd9b8f98e99457ec15a9a /gdb/symtab.c
parentc8cdc1e08312a238a9138b55ae080ceeab14845c (diff)
downloadgdb-c32e6a04f42b8e4a1392ee4b87d040c06b917ef5.zip
gdb-c32e6a04f42b8e4a1392ee4b87d040c06b917ef5.tar.gz
gdb-c32e6a04f42b8e4a1392ee4b87d040c06b917ef5.tar.bz2
Use block_enum instead of int for better typesafety
gdb/ChangeLog: 2019-07-21 Christian Biesinger <cbiesinger@google.com> * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum. (lookup_symbol_in_objfile): Change int to block_enum and add a gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
Diffstat (limited to 'gdb/symtab.c')
-rw-r--r--gdb/symtab.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 719e5b2..ce1cdcf 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -92,7 +92,8 @@ struct block_symbol lookup_local_symbol (const char *name,
enum language language);
static struct block_symbol
- lookup_symbol_in_objfile (struct objfile *objfile, int block_index,
+ lookup_symbol_in_objfile (struct objfile *objfile,
+ enum block_enum block_index,
const char *name, const domain_enum domain);
/* Type of the data stored on the program space. */
@@ -2244,8 +2245,9 @@ lookup_global_symbol_from_objfile (struct objfile *main_objfile,
static symbols. */
static struct block_symbol
-lookup_symbol_in_objfile_symtabs (struct objfile *objfile, int block_index,
- const char *name, const domain_enum domain)
+lookup_symbol_in_objfile_symtabs (struct objfile *objfile,
+ enum block_enum block_index, const char *name,
+ const domain_enum domain)
{
gdb_assert (block_index == GLOBAL_BLOCK || block_index == STATIC_BLOCK);
@@ -2516,11 +2518,13 @@ lookup_symbol_in_static_block (const char *name,
BLOCK_INDEX is one of GLOBAL_BLOCK or STATIC_BLOCK. */
static struct block_symbol
-lookup_symbol_in_objfile (struct objfile *objfile, int block_index,
+lookup_symbol_in_objfile (struct objfile *objfile, enum block_enum block_index,
const char *name, const domain_enum domain)
{
struct block_symbol result;
+ gdb_assert (block_index == GLOBAL_BLOCK || block_index == STATIC_BLOCK);
+
if (symbol_lookup_debug)
{
fprintf_unfiltered (gdb_stdlog,