diff options
author | Christian Biesinger <cbiesinger@google.com> | 2019-08-01 11:53:03 -0500 |
---|---|---|
committer | Christian Biesinger <cbiesinger@google.com> | 2019-09-20 21:09:15 -0500 |
commit | 626ca2c06f7b5a5441d512ce334bb2daf5587259 (patch) | |
tree | 723e3e58dfe155b25bd9cdab2830aee1ee976381 /gdb/symtab.c | |
parent | 40c9c8deb94be6576f5729172dce117cbe155856 (diff) | |
download | gdb-626ca2c06f7b5a5441d512ce334bb2daf5587259.zip gdb-626ca2c06f7b5a5441d512ce334bb2daf5587259.tar.gz gdb-626ca2c06f7b5a5441d512ce334bb2daf5587259.tar.bz2 |
Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order
All implementations of either function use it for the same purpose (except
Darwin, which is a no-op): to prefer a symbol in the current objfile over
symbols with the same name in other objfiles. There does not seem to be a
reason to have both mechanisms for that purpose.
gdb/ChangeLog:
2019-09-20 Christian Biesinger <cbiesinger@google.com>
* solib-darwin.c (darwin_lookup_lib_symbol): Remove.
(_initialize_darwin_solib): Don't set
darwin_so_ops.lookup_lib_global_symbol.
* solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
set_gdbarch_iterate_over_objfiles_in_search_order.
(elf_lookup_lib_symbol): Rename to...
(svr4_iterate_over_objfiles_in_search_order): this, and update
to iterate semantics.
(_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
* solib.c (solib_global_lookup): Remove.
* solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
(solib_global_lookup): Remove.
* symtab.c (lookup_global_or_static_symbol): Remove call to
solib_global_lookup.
Diffstat (limited to 'gdb/symtab.c')
-rw-r--r-- | gdb/symtab.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/gdb/symtab.c b/gdb/symtab.c index 35eab08..54c7ed9 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -2634,11 +2634,7 @@ lookup_global_or_static_symbol (const char *name, return result; } - /* Call library-specific lookup procedure. */ - if (objfile != NULL) - result = solib_global_lookup (objfile, name, domain); - - /* If that didn't work go a global search (of global blocks, heh). */ + /* Do a global search (of global blocks, heh). */ if (result.symbol == NULL) { memset (&lookup_data, 0, sizeof (lookup_data)); |