diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-06-04 13:35:44 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-06-14 12:38:15 -0600 |
| commit | f568655424ad268c8c5df3f56e4e19a86b16623d (patch) | |
| tree | 0fd9e1cb71ad7ecf7425b2c01cb7dd337bfd50f9 /gdb/symfile.c | |
| parent | a0c1ffedcf1988bc13fc5b6d57d3b74a17b60299 (diff) | |
| download | gdb-f568655424ad268c8c5df3f56e4e19a86b16623d.zip gdb-f568655424ad268c8c5df3f56e4e19a86b16623d.tar.gz gdb-f568655424ad268c8c5df3f56e4e19a86b16623d.tar.bz2 | |
Warn if add-symbol-file does not provide any symbols
A user suggested that add-symbol-file ought to warn if the file does
not in fact provide any symbols. This seemed like a decent idea, so
this patch implements this idea.
Tested on x86-64 Fedora 29.
gdb/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
* symfile.c (add_symbol_file_command): Remove obsolete comment.
Warn if symbol file does not provide any symbols.
gdb/testsuite/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
* gdb.base/symfile-warn.exp: New file.
* gdb.base/symfile-warn.c: New file.
Diffstat (limited to 'gdb/symfile.c')
| -rw-r--r-- | gdb/symfile.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/gdb/symfile.c b/gdb/symfile.c index 26762d2..6f9c81c 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -2211,12 +2211,6 @@ set_objfile_default_section_offset (struct objfile *objf, /* This function allows the addition of incrementally linked object files. It does not modify any state in the target, only in the debugger. */ -/* Note: ezannoni 2000-04-13 This function/command used to have a - special case syntax for the rombug target (Rombug is the boot - monitor for Microware's OS-9 / OS-9000, see remote-os9k.c). In the - rombug case, the user doesn't need to supply a text address, - instead a call to target_link() (in target.c) would supply the - value to use. We are now discontinuing this type of ad hoc syntax. */ static void add_symbol_file_command (const char *args, int from_tty) @@ -2358,6 +2352,9 @@ add_symbol_file_command (const char *args, int from_tty) objf = symbol_file_add (filename.get (), add_flags, §ion_addrs, flags); + if (!objfile_has_symbols (objf) && objf->per_bfd->minimal_symbol_count <= 0) + warning (_("newly-added symbol file \"%s\" does not provide any symbols"), + filename.get ()); if (seen_offset) set_objfile_default_section_offset (objf, section_addrs, offset); |