diff options
| author | Tom Tromey <tom@tromey.com> | 2018-04-29 21:02:19 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-04-30 11:33:11 -0600 |
| commit | 1831a9f9d3346dbf61202d2aba6935f0093487dd (patch) | |
| tree | 2a57de7d2ba7e20e443021aa7262f66ab9c830de /gdb/symfile-mem.c | |
| parent | 7c1b5f3db73d7ecab03dc4e866e291582935fb04 (diff) | |
| download | gdb-1831a9f9d3346dbf61202d2aba6935f0093487dd.zip gdb-1831a9f9d3346dbf61202d2aba6935f0093487dd.tar.gz gdb-1831a9f9d3346dbf61202d2aba6935f0093487dd.tar.bz2 | |
Remove new_bfd_ref
For gdb_bfd_ref_ptr, gdb already had a convenience function like the
new gdb_ref_ptr::new_reference -- called new_bfd_ref. This patch
removes it in favor of the new common function.
While doing this I also noticed that the comment for gdb_bfd_open was
incorrect (in a way related to reference counting), so this patch
updates the comment as well.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
* gdb_bfd.h (new_bfd_ref): Remove.
(gdb_bfd_open): Update comment.
* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
(gdb_bfd_fdopenr): Use new_reference.
* exec.c (exec_file_attach): Use new_reference.
Diffstat (limited to 'gdb/symfile-mem.c')
| -rw-r--r-- | gdb/symfile-mem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/symfile-mem.c b/gdb/symfile-mem.c index c060711..2e82beb 100644 --- a/gdb/symfile-mem.c +++ b/gdb/symfile-mem.c @@ -99,7 +99,7 @@ symbol_file_add_from_memory (struct bfd *templ, CORE_ADDR addr, error (_("Failed to read a valid object file image from memory.")); /* Manage the new reference for the duration of this function. */ - gdb_bfd_ref_ptr nbfd_holder = new_bfd_ref (nbfd); + gdb_bfd_ref_ptr nbfd_holder = gdb_bfd_ref_ptr::new_reference (nbfd); xfree (bfd_get_filename (nbfd)); if (name == NULL) |