diff options
| author | Tom Tromey <tom@tromey.com> | 2019-04-30 23:47:54 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-05-08 16:01:51 -0600 |
| commit | 814cf43a1f16157fcbe2c662f567d064393a0fcb (patch) | |
| tree | 66d0d0c948fdf020cd7a31849db9edc26ea138ac /gdb/symfile-debug.c | |
| parent | 02dc647ed65b1429b9af4986ed467f90fbe0c33b (diff) | |
| download | gdb-814cf43a1f16157fcbe2c662f567d064393a0fcb.zip gdb-814cf43a1f16157fcbe2c662f567d064393a0fcb.tar.gz gdb-814cf43a1f16157fcbe2c662f567d064393a0fcb.tar.bz2 | |
Convert probes to type-safe registry API
This changes the probes code in elfread.c to use the type-safe
registry API. While doing this, I saw that the caller of get_probes
owns the probes, so I went through the code and changed the vectors to
store unique_ptrs, making the ownership relationship more clear.
gdb/ChangeLog
2019-05-08 Tom Tromey <tom@tromey.com>
* symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
* symfile-debug.c (debug_sym_get_probes): Change type.
* stap-probe.c (handle_stap_probe):
(stap_static_probe_ops::get_probes): Change type.
* probe.h (class static_probe_ops) <get_probes>: Change type.
* probe.c (class any_static_probe_ops) <get_probes>: Change type.
(parse_probes_in_pspace): Update.
(find_probes_in_objfile, find_probe_by_pc, collect_probes):
Update.
(any_static_probe_ops::get_probes): Change type.
* elfread.c (elfread_data): New typedef.
(probe_key): Change type.
(elf_get_probes): Likewise. Update.
(probe_key_free): Remove.
(_initialize_elfread): Update.
* dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
Change type.
(dtrace_process_dof_probe, dtrace_process_dof)
(dtrace_static_probe_ops::get_probe): Change type.
Diffstat (limited to 'gdb/symfile-debug.c')
| -rw-r--r-- | gdb/symfile-debug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c index 8266ecb..0f9da66 100644 --- a/gdb/symfile-debug.c +++ b/gdb/symfile-debug.c @@ -382,13 +382,13 @@ static const struct quick_symbol_functions debug_sym_quick_functions = /* Debugging version of struct sym_probe_fns. */ -static const std::vector<probe *> & +static const std::vector<std::unique_ptr<probe>> & debug_sym_get_probes (struct objfile *objfile) { const struct debug_sym_fns_data *debug_data = symfile_debug_objfile_data_key.get (objfile); - const std::vector<probe *> &retval + const std::vector<std::unique_ptr<probe>> &retval = debug_data->real_sf->sym_probe_fns->sym_get_probes (objfile); fprintf_filtered (gdb_stdlog, |