diff options
| author | Tom Tromey <tom@tromey.com> | 2019-04-30 23:47:54 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-05-08 16:01:51 -0600 |
| commit | 814cf43a1f16157fcbe2c662f567d064393a0fcb (patch) | |
| tree | 66d0d0c948fdf020cd7a31849db9edc26ea138ac /gdb/stap-probe.c | |
| parent | 02dc647ed65b1429b9af4986ed467f90fbe0c33b (diff) | |
| download | gdb-814cf43a1f16157fcbe2c662f567d064393a0fcb.zip gdb-814cf43a1f16157fcbe2c662f567d064393a0fcb.tar.gz gdb-814cf43a1f16157fcbe2c662f567d064393a0fcb.tar.bz2 | |
Convert probes to type-safe registry API
This changes the probes code in elfread.c to use the type-safe
registry API. While doing this, I saw that the caller of get_probes
owns the probes, so I went through the code and changed the vectors to
store unique_ptrs, making the ownership relationship more clear.
gdb/ChangeLog
2019-05-08 Tom Tromey <tom@tromey.com>
* symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
* symfile-debug.c (debug_sym_get_probes): Change type.
* stap-probe.c (handle_stap_probe):
(stap_static_probe_ops::get_probes): Change type.
* probe.h (class static_probe_ops) <get_probes>: Change type.
* probe.c (class any_static_probe_ops) <get_probes>: Change type.
(parse_probes_in_pspace): Update.
(find_probes_in_objfile, find_probe_by_pc, collect_probes):
Update.
(any_static_probe_ops::get_probes): Change type.
* elfread.c (elfread_data): New typedef.
(probe_key): Change type.
(elf_get_probes): Likewise. Update.
(probe_key_free): Remove.
(_initialize_elfread): Update.
* dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
Change type.
(dtrace_process_dof_probe, dtrace_process_dof)
(dtrace_static_probe_ops::get_probe): Change type.
Diffstat (limited to 'gdb/stap-probe.c')
| -rw-r--r-- | gdb/stap-probe.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/gdb/stap-probe.c b/gdb/stap-probe.c index 24b2b78..e70940c 100644 --- a/gdb/stap-probe.c +++ b/gdb/stap-probe.c @@ -106,7 +106,7 @@ public: bool is_linespec (const char **linespecp) const override; /* See probe.h. */ - void get_probes (std::vector<probe *> *probesp, + void get_probes (std::vector<std::unique_ptr<probe>> *probesp, struct objfile *objfile) const override; /* See probe.h. */ @@ -1497,7 +1497,8 @@ stap_probe::gen_info_probes_table_values () const static void handle_stap_probe (struct objfile *objfile, struct sdt_note *el, - std::vector<probe *> *probesp, CORE_ADDR base) + std::vector<std::unique_ptr<probe>> *probesp, + CORE_ADDR base) { bfd *abfd = objfile->obfd; int size = bfd_get_arch_size (abfd) / 8; @@ -1561,7 +1562,7 @@ handle_stap_probe (struct objfile *objfile, struct sdt_note *el, address, gdbarch, sem_addr, probe_args); /* Successfully created probe. */ - probesp->push_back (ret); + probesp->emplace_back (ret); } /* Helper function which tries to find the base address of the SystemTap @@ -1615,8 +1616,9 @@ stap_static_probe_ops::is_linespec (const char **linespecp) const /* Implementation of the 'get_probes' method. */ void -stap_static_probe_ops::get_probes (std::vector<probe *> *probesp, - struct objfile *objfile) const +stap_static_probe_ops::get_probes + (std::vector<std::unique_ptr<probe>> *probesp, + struct objfile *objfile) const { /* If we are here, then this is the first time we are parsing the SystemTap probe's information. We basically have to count how many |