diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-08-02 08:12:31 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-08-05 07:36:28 -0600 |
| commit | 8abfcabcb49fcd8b95854a5b59e7928e3c6000ff (patch) | |
| tree | 893690767cf48b6862208522976afc8d9c9183f3 /gdb/stack.c | |
| parent | 23d188c74e7481bb0af3c42b84fc9cb0c94267e5 (diff) | |
| download | gdb-8abfcabcb49fcd8b95854a5b59e7928e3c6000ff.zip gdb-8abfcabcb49fcd8b95854a5b59e7928e3c6000ff.tar.gz gdb-8abfcabcb49fcd8b95854a5b59e7928e3c6000ff.tar.bz2 | |
Use _() in calls to build_help
Currently some code in gdb uses build_help with N_(), like:
static const std::string compile_print_help
= gdb::option::build_help (N_("\
I believe this is incorrect. The N_ macro is used to mark text that
should end up in the message catalog, but which will be translated by
a later call to gettext.
However, in this case, there is no later call to gettext, so (if gdb
had translations), this text would remain untranslated.
Instead, I think using the ordinary _() macro is correct here.
Translators will have to know to preserve "%OPTIONS%" in the text --
but that seems both unavoidable and fine.
Tested by rebuilding as there's not much else to do.
gdb/ChangeLog
2019-08-05 Tom Tromey <tromey@adacore.com>
* compile/compile.c (_initialize_compile): Use _(), not N_().
* thread.c (_initialize_thread): Use _(), not N_().
* stack.c (_initialize_stack): Use _(), not N_().
* printcmd.c (_initialize_printcmd): Use _(), not N_().
Diffstat (limited to 'gdb/stack.c')
| -rw-r--r-- | gdb/stack.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/stack.c b/gdb/stack.c index 7833ca4..0dd7057 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -3275,7 +3275,7 @@ Options:\n\ const auto frame_apply_opts = make_frame_apply_options_def_group (nullptr, nullptr); - static std::string frame_apply_cmd_help = gdb::option::build_help (N_("\ + static std::string frame_apply_cmd_help = gdb::option::build_help (_("\ Apply a command to a number of frames.\n\ Usage: frame apply COUNT [OPTION]... COMMAND\n\ With a negative COUNT argument, applies the command on outermost -COUNT frames.\n" @@ -3288,7 +3288,7 @@ With a negative COUNT argument, applies the command on outermost -COUNT frames.\ &frame_cmd_list); set_cmd_completer_handle_brkchars (cmd, frame_apply_cmd_completer); - static std::string frame_apply_all_cmd_help = gdb::option::build_help (N_("\ + static std::string frame_apply_all_cmd_help = gdb::option::build_help (_("\ Apply a command to all frames.\n\ \n\ Usage: frame apply all [OPTION]... COMMAND\n" @@ -3300,7 +3300,7 @@ Usage: frame apply all [OPTION]... COMMAND\n" &frame_apply_cmd_list); set_cmd_completer_handle_brkchars (cmd, frame_apply_all_cmd_completer); - static std::string frame_apply_level_cmd_help = gdb::option::build_help (N_("\ + static std::string frame_apply_level_cmd_help = gdb::option::build_help (_("\ Apply a command to a list of frames.\n\ \n\ Usage: frame apply level LEVEL... [OPTION]... COMMAND\n\ @@ -3407,7 +3407,7 @@ Usage: select-frame level LEVEL"), = make_backtrace_options_def_group (nullptr, nullptr, nullptr); static std::string backtrace_help - = gdb::option::build_help (N_("\ + = gdb::option::build_help (_("\ Print backtrace of all stack frames, or innermost COUNT frames.\n\ Usage: backtrace [OPTION]... [QUALIFIER]... [COUNT | -COUNT]\n\ \n\ |