diff options
author | Andrew Cagney <cagney@redhat.com> | 2003-04-06 18:36:23 +0000 |
---|---|---|
committer | Andrew Cagney <cagney@redhat.com> | 2003-04-06 18:36:23 +0000 |
commit | e6ba3bc976d3e71e13c550474c2c39463e2bdecc (patch) | |
tree | 48fdd6c3e5680c01f761e80b0af154e60c6410cf /gdb/sparc-tdep.c | |
parent | 996179eebb352d0242007cecc12d41c67d4982ba (diff) | |
download | gdb-e6ba3bc976d3e71e13c550474c2c39463e2bdecc.zip gdb-e6ba3bc976d3e71e13c550474c2c39463e2bdecc.tar.gz gdb-e6ba3bc976d3e71e13c550474c2c39463e2bdecc.tar.bz2 |
2003-04-06 Andrew Cagney <cagney@redhat.com>
* frame.h (legacy_frame_chain_valid): Rename frame_chain_valid.
Update comment.
* frame.c (legacy_saved_regs_this_id): Update.
(legacy_get_prev_frame): Update.
* xstormy16-tdep.c: Update comment.
* sparc-tdep.c (sparc_frame_chain): Update comment.
* blockframe.c (legacy_frame_chain_valid): Update.
Diffstat (limited to 'gdb/sparc-tdep.c')
-rw-r--r-- | gdb/sparc-tdep.c | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c index da50574..7a54b8f 100644 --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -437,16 +437,17 @@ sparc_frame_chain (struct frame_info *frame) about the chain value. If it really is zero, we detect it later in sparc_init_prev_frame. - Note: kevinb/2003-02-18: The constant 1 used to be returned - here, but, after some recent changes to frame_chain_valid(), - this value is no longer suitable for causing frame_chain_valid() - to "not worry about the chain value." The constant ~0 (i.e, - 0xfff...) causes the failing test in frame_chain_valid() to - succeed thus preserving the "not worry" property. I had considered - using something like ``get_frame_base (frame) + 1''. However, I think - a constant value is better, because when debugging this problem, - I knew that something funny was going on as soon as I saw the - constant 1 being used as the frame chain elsewhere in GDB. */ + Note: kevinb/2003-02-18: The constant 1 used to be returned here, + but, after some recent changes to legacy_frame_chain_valid(), + this value is no longer suitable for causing + legacy_frame_chain_valid() to "not worry about the chain value." + The constant ~0 (i.e, 0xfff...) causes the failing test in + legacy_frame_chain_valid() to succeed thus preserving the "not + worry" property. I had considered using something like + ``get_frame_base (frame) + 1''. However, I think a constant + value is better, because when debugging this problem, I knew that + something funny was going on as soon as I saw the constant 1 + being used as the frame chain elsewhere in GDB. */ return ~ (CORE_ADDR) 0; } |