diff options
author | Christian Biesinger <cbiesinger@google.com> | 2019-08-01 11:53:03 -0500 |
---|---|---|
committer | Christian Biesinger <cbiesinger@google.com> | 2019-09-20 21:09:15 -0500 |
commit | 626ca2c06f7b5a5441d512ce334bb2daf5587259 (patch) | |
tree | 723e3e58dfe155b25bd9cdab2830aee1ee976381 /gdb/solib.c | |
parent | 40c9c8deb94be6576f5729172dce117cbe155856 (diff) | |
download | gdb-626ca2c06f7b5a5441d512ce334bb2daf5587259.zip gdb-626ca2c06f7b5a5441d512ce334bb2daf5587259.tar.gz gdb-626ca2c06f7b5a5441d512ce334bb2daf5587259.tar.bz2 |
Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order
All implementations of either function use it for the same purpose (except
Darwin, which is a no-op): to prefer a symbol in the current objfile over
symbols with the same name in other objfiles. There does not seem to be a
reason to have both mechanisms for that purpose.
gdb/ChangeLog:
2019-09-20 Christian Biesinger <cbiesinger@google.com>
* solib-darwin.c (darwin_lookup_lib_symbol): Remove.
(_initialize_darwin_solib): Don't set
darwin_so_ops.lookup_lib_global_symbol.
* solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
set_gdbarch_iterate_over_objfiles_in_search_order.
(elf_lookup_lib_symbol): Rename to...
(svr4_iterate_over_objfiles_in_search_order): this, and update
to iterate semantics.
(_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
* solib.c (solib_global_lookup): Remove.
* solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
(solib_global_lookup): Remove.
* symtab.c (lookup_global_or_static_symbol): Remove call to
solib_global_lookup.
Diffstat (limited to 'gdb/solib.c')
-rw-r--r-- | gdb/solib.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/gdb/solib.c b/gdb/solib.c index b9a61e2..5b12469 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -1441,21 +1441,6 @@ show_auto_solib_add (struct ui_file *file, int from_tty, } -/* Handler for library-specific lookup of global symbol NAME in OBJFILE. Call - the library-specific handler if it is installed for the current target. */ - -struct block_symbol -solib_global_lookup (struct objfile *objfile, - const char *name, - const domain_enum domain) -{ - const struct target_so_ops *ops = solib_ops (target_gdbarch ()); - - if (ops->lookup_lib_global_symbol != NULL) - return ops->lookup_lib_global_symbol (objfile, name, domain); - return {}; -} - /* Lookup the value for a specific symbol from dynamic symbol table. Look up symbol from ABFD. MATCH_SYM is a callback function to determine whether to pick up a symbol. DATA is the input of this callback |