diff options
| author | Tom Tromey <tom@tromey.com> | 2019-11-01 16:21:04 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-12-12 15:50:52 -0700 |
| commit | 268e4f09144c48e02f01d82ab3aab359457df214 (patch) | |
| tree | 8685bc0ca92837f6f41a97059378b1b12d44cf96 /gdb/solib.c | |
| parent | f65fe5704af56aca58fd5547d0841a9512e540af (diff) | |
| download | gdb-268e4f09144c48e02f01d82ab3aab359457df214.zip gdb-268e4f09144c48e02f01d82ab3aab359457df214.tar.gz gdb-268e4f09144c48e02f01d82ab3aab359457df214.tar.bz2 | |
Make the objfile destructor private
The idea behind this is that, in the long run, some code will need to
be able to hold onto an objfile after it is unlinked from the program
space. In particular, this is needed for some functionality to be
moved to worker threads -- otherwise the objfile can be deleted while
still in use.
So, this makes ~objfile private, replacing it with an "unlink" method,
making it more obvious which operation is intended at the calling
points.
gdb/ChangeLog
2019-12-12 Tom Tromey <tom@tromey.com>
* symfile.c (syms_from_objfile_1): Use objfile_up.
(syms_from_objfile_1, remove_symbol_file_command): Call unlink
method.
(reread_symbols): Use objfile_up.
* solib.c (update_solib_list, reload_shared_libraries_1): Call
unlink method.
* objfiles.h (struct objfile) <~objfile>: Now private.
<unlink>: New method.
(struct objfile_deleter): New.
(objfile_up): New typedef.
* objfiles.c (objfile::unlink): New method.
(free_objfile_separate_debug, free_all_objfiles)
(objfile_purge_solibs): Use it.
* jit.c (jit_unregister_code): Remove.
(jit_inferior_exit_hook, jit_event_handler): Call unlink on
objfile.
* compile/compile-object-run.c (do_module_cleanup): Call unlink on
objfile.
* compile/compile-object-load.c (compile_object_load): Use
objfile_up.
Change-Id: I934bee70b26b8b24e1735828fb1e60fe8a05714f
Diffstat (limited to 'gdb/solib.c')
| -rw-r--r-- | gdb/solib.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/solib.c b/gdb/solib.c index 5483670..7eea732 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -835,7 +835,7 @@ update_solib_list (int from_tty) /* Unless the user loaded it explicitly, free SO's objfile. */ if (gdb->objfile && ! (gdb->objfile->flags & OBJF_USERLOADED) && !solib_used (gdb)) - delete gdb->objfile; + gdb->objfile->unlink (); /* Some targets' section tables might be referring to sections from so->abfd; remove them. */ @@ -1312,7 +1312,7 @@ reload_shared_libraries_1 (int from_tty) { if (so->objfile && ! (so->objfile->flags & OBJF_USERLOADED) && !solib_used (so)) - delete so->objfile; + so->objfile->unlink (); remove_target_sections (so); clear_so (so); } |