aboutsummaryrefslogtreecommitdiff
path: root/gdb/solib-svr4.c
diff options
context:
space:
mode:
authorTom Tromey <tromey@redhat.com>2012-07-23 15:25:12 +0000
committerTom Tromey <tromey@redhat.com>2012-07-23 15:25:12 +0000
commit695c31738b1a1f052f777630bd914b7f3f783b9b (patch)
treed8fc26c059036a118ad89b6895cab42507449481 /gdb/solib-svr4.c
parent08d2cd740c0c9ca78c849cf14e3470f0b8823139 (diff)
downloadgdb-695c31738b1a1f052f777630bd914b7f3f783b9b.zip
gdb-695c31738b1a1f052f777630bd914b7f3f783b9b.tar.gz
gdb-695c31738b1a1f052f777630bd914b7f3f783b9b.tar.bz2
* solib-svr4.c (enable_break): Update.
* bfd-target.h (target_bfd_reopen): Update documentation.
Diffstat (limited to 'gdb/solib-svr4.c')
-rw-r--r--gdb/solib-svr4.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 307e483..76bd872 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -46,6 +46,7 @@
#include "exec.h"
#include "auxv.h"
#include "exceptions.h"
+#include "gdb_bfd.h"
static struct link_map_offsets *svr4_fetch_link_map_offsets (void);
static int svr4_have_link_map_offsets (void);
@@ -1558,9 +1559,11 @@ enable_break (struct svr4_info *info, int from_tty)
goto bkpt_at_symbol;
/* Now convert the TMP_BFD into a target. That way target, as
- well as BFD operations can be used. Note that closing the
- target will also close the underlying bfd. */
+ well as BFD operations can be used. */
tmp_bfd_target = target_bfd_reopen (tmp_bfd);
+ /* target_bfd_reopen acquired its own reference, so we can
+ release ours now. */
+ gdb_bfd_unref (tmp_bfd);
/* On a running target, we can get the dynamic linker's base
address from the shared library table. */
@@ -1670,8 +1673,9 @@ enable_break (struct svr4_info *info, int from_tty)
sym_addr,
tmp_bfd_target);
- /* We're done with both the temporary bfd and target. Remember,
- closing the target closes the underlying bfd. */
+ /* We're done with both the temporary bfd and target. Closing
+ the target closes the underlying bfd, because it holds the
+ only remaining reference. */
target_close (tmp_bfd_target, 0);
if (sym_addr != 0)