diff options
| author | Tom Tromey <tromey@redhat.com> | 2012-07-18 19:34:57 +0000 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2012-07-18 19:34:57 +0000 |
| commit | a4453b7e0b9b84dd18c844ef43fbb9f6e2e75433 (patch) | |
| tree | 86d872256f3fb47092c6660448c7f7655748e2b7 /gdb/solib-darwin.c | |
| parent | cbb099e88685f8aa80b9a958ba35988d8dbb8721 (diff) | |
| download | gdb-a4453b7e0b9b84dd18c844ef43fbb9f6e2e75433.zip gdb-a4453b7e0b9b84dd18c844ef43fbb9f6e2e75433.tar.gz gdb-a4453b7e0b9b84dd18c844ef43fbb9f6e2e75433.tar.bz2 | |
* symfile.c (symfile_bfd_open): Don't copy name. Call
gdb_bfd_stash_filename.
(load_command): Open the new BFD before freeing the old.
(bfd_open_maybe_remote): Call gdb_bfd_stash_filename.
* symfile-mem.c (symbol_file_add_from_memory): Don't copy name.
Call gdb_bfd_stash_filename.
* spu-linux-nat.c (spu_bfd_open): Don't copy name.
* solib-spu.c (spu_bfd_fopen): Don't copy name. Call
gdb_bfd_stash_filename.
* solib-darwin.c (darwin_solib_get_all_image_info_addr_at_init):
Free found_pathname.
* rs6000-nat.c (add_vmap): Don't copy filename. Call
gdb_bfd_stash_filename.
* remote.c (remote_bfd_open): Call gdb_bfd_stash_filename.
* machoread.c (macho_add_oso_symfile): Call
gdb_bfd_stash_filename.
(macho_symfile_read_all_oso): Arrange to free archive_name. Call
gdb_bfd_stash_filename.
(macho_check_dsym): Don't copy filename. Call
gdb_bfd_stash_filename.
* jit.c (bfd_open_from_target_memory): Don't copy the filename.
* gdb_bfd.c (gdb_bfd_stash_filename): New function.
* gdb_bfd.h (gdb_bfd_stash_filename): Declare.
* gcore.c (create_gcore_bfd): Call gdb_bfd_stash_filename.
* exec.c (exec_close): Don't free the BFD's filename.
(exec_file_attach): Don't copy the filename. Call
gdb_bfd_stash_filename.
* corelow.c (core_close): Don't free the BFD's filename.
(core_open): Call gdb_bfd_stash_filename.
* corefile.c (reopen_exec_file): Remove #if 0 code.
* solib.c (solib_bfd_fopen): Call gdb_bfd_stash_filename. Free
pathname.
* dwarf2read.c (try_open_dwo_file): Call gdb_bfd_stash_filename.
Diffstat (limited to 'gdb/solib-darwin.c')
| -rw-r--r-- | gdb/solib-darwin.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c index bc2cd79..242f8cc 100644 --- a/gdb/solib-darwin.c +++ b/gdb/solib-darwin.c @@ -510,17 +510,10 @@ darwin_bfd_open (char *pathname) gdbarch_bfd_arch_info (target_gdbarch)); if (!res) { - gdb_bfd_unref (abfd); - make_cleanup (xfree, found_pathname); + make_cleanup_bfd_close (abfd); error (_("`%s': not a shared-library: %s"), - found_pathname, bfd_errmsg (bfd_get_error ())); + bfd_get_filename (abfd), bfd_errmsg (bfd_get_error ())); } - - /* Make sure that the filename is malloc'ed. The current filename - for fat-binaries BFDs is a name that was generated by BFD, usually - a static string containing the name of the architecture. */ - res->filename = xstrdup (pathname); - return res; } |