aboutsummaryrefslogtreecommitdiff
path: root/gdb/solib-darwin.c
diff options
context:
space:
mode:
authorHui Zhu <teawater@gmail.com>2014-01-07 00:24:41 +0800
committerHui Zhu <teawater@gmail.com>2014-01-07 00:24:41 +0800
commitadcf2eed05bb041ba579d74102c18ea1e97b29d6 (patch)
tree54836e00abea7a4194e2ca56c46f72d6f769570e /gdb/solib-darwin.c
parentb0b0c9fc49b72ec4f0f38419f20bcafcae9736d8 (diff)
downloadgdb-adcf2eed05bb041ba579d74102c18ea1e97b29d6.zip
gdb-adcf2eed05bb041ba579d74102c18ea1e97b29d6.tar.gz
gdb-adcf2eed05bb041ba579d74102c18ea1e97b29d6.tar.bz2
Remove gdb_bfd_stash_filename to fix crash with fix of binutils/11983
https://sourceware.org/ml/gdb-patches/2014-01/msg00029.html https://sourceware.org/ml/gdb-patches/2014-01/msg00053.html 2014-01-07 Hui Zhu <hui@codesourcery.com> * gdb_bfd.c (gdb_bfd_stash_filename): Removed. (gdb_bfd_open): Removed gdb_bfd_stash_filename. (gdb_bfd_fopen): Ditto. (gdb_bfd_openr): Ditto. (gdb_bfd_openw): Ditto. (gdb_bfd_openr_iovec): Ditto. (gdb_bfd_fdopenr): Ditto. * gdb_bfd.h (gdb_bfd_stash_filename): Removed. * solib-aix.c (solib_aix_bfd_open): Alloc object_bfd->filename with xstrdup. * solib-darwin.c (darwin_bfd_open): Alloc res->filename with xstrdup. * symfile-mem.c (symbol_file_add_from_memory): Removed gdb_bfd_stash_filename.
Diffstat (limited to 'gdb/solib-darwin.c')
-rw-r--r--gdb/solib-darwin.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c
index 792a18a..ba807a2 100644
--- a/gdb/solib-darwin.c
+++ b/gdb/solib-darwin.c
@@ -621,12 +621,8 @@ darwin_bfd_open (char *pathname)
/* The current filename for fat-binary BFDs is a name generated
by BFD, usually a string containing the name of the architecture.
Reset its value to the actual filename. */
- {
- char *data = bfd_alloc (res, strlen (pathname) + 1);
-
- strcpy (data, pathname);
- res->filename = data;
- }
+ xfree (bfd_get_filename (res));
+ res->filename = xstrdup (pathname);
gdb_bfd_unref (abfd);
return res;