diff options
author | Jason Molenda <jmolenda@apple.com> | 1998-10-16 21:45:06 +0000 |
---|---|---|
committer | Jason Molenda <jmolenda@apple.com> | 1998-10-16 21:45:06 +0000 |
commit | 24418cfbac29d947c943d05c14a00e918cff79d7 (patch) | |
tree | 106392351866526f20e7f89c5a03d89f32aa9984 /gdb/ser-tcp.c | |
parent | 2b6f11fa0b8305e5086d496d8cd4d39c28b8a2df (diff) | |
download | gdb-24418cfbac29d947c943d05c14a00e918cff79d7.zip gdb-24418cfbac29d947c943d05c14a00e918cff79d7.tar.gz gdb-24418cfbac29d947c943d05c14a00e918cff79d7.tar.bz2 |
1998-10-16 Jason Molenda (jsm@bugshack.cygnus.com)
* command.c copying.c copying.awk core-aout.c core-regset.c
corelow.c dcache.c i386-tdep.c i386v4-nat.c i387-tdep.c
infcmd.c infptrace.c infrun.c remote.c solib.c symfile.c
symmisc.c valarith.c: Add prototypes.
* defs.h: Add prototype for utils.c::do_run_cleanups.
* gdbtypes.c: Add prototypes.
(make_pointer_type): Add braces to remove nested if-else ambiguity.
(make_reference_type): Ditto.
* printcmd.c (printf_command): Initialize 'f' and 'string' at
function startup to suppress possibly-used-before-initialized warning.
* remote-utils.c: Add prototypes.
(sr_pollchar): Add braces to remove nested if-else ambiguity.
* ser-tcp.c: Add prototypes.
(wait_for): Add braces to remove nested if-else ambiguity.
(tcp_readchar): Ditto.
* ser-unix.c: Add prototypes.
(get_tty_state): Don't define errno here.
(get_tty_state): Don't define errno here.
(hardwire_readchar): Only define 't' if we are compiling in a Cygwin
environment.
* symtab.c: Add prototypes.
(find_methods): Add braces to remove nested if-else ambiguity.
(search_symbols): Set 'i' to an initial value to suppress a
possibly-used-before-initialized warning.
* valops.c: Add prototypes.
(value_cast): Set 'eltype2' to an initial value to suppress a
possibly-used-before-initialized warning.
(value_of_variable): Add braces to remove nested if-else ambiguity.
(value_of_this): Ditto.
* valprint.c: Add prototypes.
(print_floating): Add braces to remove nested if-else ambiguity.
Looks like a big change, but it is really just a lot of small stuff.
In the cases where GCC was flagging a possible use-before-initialized
warning on variables, it turned out that these were being used properly
but GCC couldn't see that.
Diffstat (limited to 'gdb/ser-tcp.c')
-rw-r--r-- | gdb/ser-tcp.c | 36 |
1 files changed, 21 insertions, 15 deletions
diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c index 279cbd0..c551337 100644 --- a/gdb/ser-tcp.c +++ b/gdb/ser-tcp.c @@ -1,5 +1,5 @@ /* Serial interface for raw TCP connections on Un*x like systems - Copyright 1992, 1993 Free Software Foundation, Inc. + Copyright 1992, 1993, 1998 Free Software Foundation, Inc. This file is part of GDB. @@ -54,6 +54,8 @@ static int tcp_noflush_set_tty_state PARAMS ((serial_t, serial_ttystate, serial_ttystate)); static void tcp_print_tty_state PARAMS ((serial_t, serial_ttystate)); +void _initialize_ser_tcp PARAMS ((void)); + /* Open up a raw tcp socket */ static int @@ -183,7 +185,7 @@ tcp_raw(scb) */ static int -wait_for(scb, timeout) +wait_for (scb, timeout) serial_t scb; int timeout; { @@ -208,12 +210,14 @@ wait_for(scb, timeout) numfds = select(scb->fd+1, &readfds, 0, &exceptfds, 0); if (numfds <= 0) - if (numfds == 0) - return SERIAL_TIMEOUT; - else if (errno == EINTR) - continue; - else - return SERIAL_ERROR; /* Got an error from select or poll */ + { + if (numfds == 0) + return SERIAL_TIMEOUT; + else if (errno == EINTR) + continue; + else + return SERIAL_ERROR; /* Got an error from select or poll */ + } return 0; } @@ -225,7 +229,7 @@ wait_for(scb, timeout) dead, or -3 for any other error (see errno in that case). */ static int -tcp_readchar(scb, timeout) +tcp_readchar (scb, timeout) serial_t scb; int timeout; { @@ -247,12 +251,14 @@ tcp_readchar(scb, timeout) } if (scb->bufcnt <= 0) - if (scb->bufcnt == 0) - return SERIAL_TIMEOUT; /* 0 chars means timeout [may need to - distinguish between EOF & timeouts - someday] */ - else - return SERIAL_ERROR; /* Got an error from read */ + { + if (scb->bufcnt == 0) + return SERIAL_TIMEOUT; /* 0 chars means timeout [may need to + distinguish between EOF & timeouts + someday] */ + else + return SERIAL_ERROR; /* Got an error from read */ + } scb->bufcnt--; scb->bufp = scb->buf; |