diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-06-28 11:49:22 -0400 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-06-28 11:49:22 -0400 |
commit | b447dd03c16d51c7b41c9af0756fc9db4ad95f0d (patch) | |
tree | 4cff1537b99c800351a42d293650b7c51459e710 /gdb/rs6000-tdep.c | |
parent | c87c999c511f0484de53fa616b0bf6b00c753434 (diff) | |
download | gdb-b447dd03c16d51c7b41c9af0756fc9db4ad95f0d.zip gdb-b447dd03c16d51c7b41c9af0756fc9db4ad95f0d.tar.gz gdb-b447dd03c16d51c7b41c9af0756fc9db4ad95f0d.tar.bz2 |
gdb: remove gdbarch_info_init
While reviewing another patch, I realized that gdbarch_info_init could
easily be removed in favor of initializing gdbarch_info fields directly
in the struct declaration. The only odd part is the union. I don't
know if it's actually important for it to be zero-initialized, but I
presume it is. I added a constructor to gdbarch_info to take care of
that. A proper solution would be to use std::variant. Or, these could
also be separate fields, the little extra space required wouldn't
matter.
gdb/ChangeLog:
* gdbarch.sh (struct gdbarch_info): Initialize fields, add
constructor.
* gdbarch.h: Re-generate.
* arch-utils.h (gdbarch_info_init): Remove, delete all usages.
* arch-utils.c (gdbarch_info_init): Remove.
Change-Id: I7502e08fe0f278d84eef1667a072e8a97bda5ab5
Diffstat (limited to 'gdb/rs6000-tdep.c')
-rw-r--r-- | gdb/rs6000-tdep.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 5bcf5fc..a629450 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -7260,7 +7260,6 @@ powerpc_set_soft_float (const char *args, int from_tty, struct gdbarch_info info; /* Update the architecture. */ - gdbarch_info_init (&info); if (!gdbarch_update_p (info)) internal_error (__FILE__, __LINE__, _("could not update architecture")); } @@ -7269,7 +7268,6 @@ static void powerpc_set_vector_abi (const char *args, int from_tty, struct cmd_list_element *c) { - struct gdbarch_info info; int vector_abi; for (vector_abi = POWERPC_VEC_AUTO; @@ -7287,7 +7285,7 @@ powerpc_set_vector_abi (const char *args, int from_tty, powerpc_vector_abi_string); /* Update the architecture. */ - gdbarch_info_init (&info); + gdbarch_info info; if (!gdbarch_update_p (info)) internal_error (__FILE__, __LINE__, _("could not update architecture")); } |