diff options
| author | Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> | 2014-09-12 09:20:25 -0300 |
|---|---|---|
| committer | Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> | 2014-09-12 09:20:25 -0300 |
| commit | 9d9bf2df89db515958b429a1aeb1db38884ba488 (patch) | |
| tree | f78704b2e32a42dc858664f2d5758bd2913bf5ec /gdb/rs6000-tdep.c | |
| parent | 1cf2f1b045e9e647f6dfd28829ff4592c588dcb7 (diff) | |
| download | gdb-9d9bf2df89db515958b429a1aeb1db38884ba488.zip gdb-9d9bf2df89db515958b429a1aeb1db38884ba488.tar.gz gdb-9d9bf2df89db515958b429a1aeb1db38884ba488.tar.bz2 | |
PR tdep/17379: Fix internal-error when stack pointer is invalid.
The problem is that rs6000_frame_cache attempts to read the stack backchain via
read_memory_unsigned_integer, which throws an exception if the stack pointer is
invalid. With this patch, it calls safe_read_memory_integer instead, which
doesn't throw an exception and allows for safe handling of that situation.
gdb/ChangeLog
2014-09-12 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Ulrich Weigand <uweigand@de.ibm.com>
PR tdep/17379
* rs6000-tdep.c (rs6000_frame_cache): Use safe_read_memory_integer
instead of read_memory_unsigned_integer.
gdb/testcase/ChangeLog
2014-09-12 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
PR tdep/17379
* gdb.arch/powerpc-stackless.S: New file.
* gdb.arch/powerpc-stackless.exp: New file.
Diffstat (limited to 'gdb/rs6000-tdep.c')
| -rw-r--r-- | gdb/rs6000-tdep.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 730afe7..dabf448 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -3190,9 +3190,14 @@ rs6000_frame_cache (struct frame_info *this_frame, void **this_cache) } if (!fdata.frameless) - /* Frameless really means stackless. */ - cache->base - = read_memory_unsigned_integer (cache->base, wordsize, byte_order); + { + /* Frameless really means stackless. */ + LONGEST backchain; + + if (safe_read_memory_integer (cache->base, wordsize, + byte_order, &backchain)) + cache->base = (CORE_ADDR) backchain; + } trad_frame_set_value (cache->saved_regs, gdbarch_sp_regnum (gdbarch), cache->base); |