diff options
| author | Yao Qi <yao.qi@linaro.org> | 2016-11-03 14:35:13 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2016-11-03 14:35:13 +0000 |
| commit | 598cc9dc84aeaa66e4a77efa9dc8ff03d5532620 (patch) | |
| tree | 893c53ac4f0f6e383420bc890802b740f493e091 /gdb/rl78-tdep.c | |
| parent | 8b55a7e4e5b30877e924e4b0ed0437d16ccdcedf (diff) | |
| download | gdb-598cc9dc84aeaa66e4a77efa9dc8ff03d5532620.zip gdb-598cc9dc84aeaa66e4a77efa9dc8ff03d5532620.tar.gz gdb-598cc9dc84aeaa66e4a77efa9dc8ff03d5532620.tar.bz2 | |
GDBARCH_BREAKPOINT_MANIPULATION and SET_GDBARCH_BREAKPOINT_MANIPULATION
Many archs have only one kind of breakpoint, so their breakpoint_from_pc
implementations are quite similar. This patch uses macro
GDBARCH_BREAKPOINT_MANIPULATION and SET_GDBARCH_BREAKPOINT_MANIPULATION
for breakpoint_from_pc, so that we can easily switch from
breakpoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind
later.
gdb:
2016-11-03 Yao Qi <yao.qi@linaro.org>
* arch-utils.h (GDBARCH_BREAKPOINT_MANIPULATION): New macro.
(SET_GDBARCH_BREAKPOINT_MANIPULATION): New macro.
aarch64-tdep.c (aarch64_breakpoint_from_pc): Remove. Use
GDBARCH_BREAKPOINT_MANIPULATION.
(aarch64_gdbarch_init): Replace set_gdbarch_breakpoint_from_pc
with SET_GDBARCH_BREAKPOINT_MANIPULATION.
* alpha-tdep.c: Likewise.
* avr-tdep.c: Likewise.
* frv-tdep.c: Likewise.
* ft32-tdep.c: Likewise.
* h8300-tdep.c: Likewise.
* hppa-tdep.c: Likewise.
* i386-tdep.c: Likewise.
* lm32-tdep.c: Likewise.
* m32c-tdep.c: Likewise.
* m68hc11-tdep.c: Likewise.
* m68k-tdep.c: Likewise.
* m88k-tdep.c: Likewise.
* mep-tdep.c: Likewise.
* microblaze-tdep.c: Likewise.
* mn10300-tdep.c: Likewise.
* moxie-tdep.c: Likewise.
* msp430-tdep.c: Likewise.
* rl78-tdep.c: Likewise.
* rx-tdep.c: Likewise.
* s390-linux-tdep.c: Likewise.
* sparc-tdep.c: Likewise.
* spu-tdep.c: Likewise.
* tilegx-tdep.c: Likewise.
* vax-tdep.c: Likewise.
* xstormy16-tdep.c: Likewise.
Diffstat (limited to 'gdb/rl78-tdep.c')
| -rw-r--r-- | gdb/rl78-tdep.c | 22 |
1 files changed, 7 insertions, 15 deletions
diff --git a/gdb/rl78-tdep.c b/gdb/rl78-tdep.c index 4818d38..1e9d435 100644 --- a/gdb/rl78-tdep.c +++ b/gdb/rl78-tdep.c @@ -768,21 +768,13 @@ rl78_pseudo_register_write (struct gdbarch *gdbarch, gdb_assert_not_reached ("invalid pseudo register number"); } -/* Implement the "breakpoint_from_pc" gdbarch method. */ +/* The documented BRK instruction is actually a two byte sequence, + {0x61, 0xcc}, but instructions may be as short as one byte. + Correspondence with Renesas revealed that the one byte sequence + 0xff is used when a one byte breakpoint instruction is required. */ +static gdb_byte breakpoint[] = { 0xff }; -static const gdb_byte * -rl78_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr, - int *lenptr) -{ - /* The documented BRK instruction is actually a two byte sequence, - {0x61, 0xcc}, but instructions may be as short as one byte. - Correspondence with Renesas revealed that the one byte sequence - 0xff is used when a one byte breakpoint instruction is required. */ - static gdb_byte breakpoint[] = { 0xff }; - - *lenptr = sizeof breakpoint; - return breakpoint; -} +GDBARCH_BREAKPOINT_MANIPULATION (rl78, breakpoint) /* Define a "handle" struct for fetching the next opcode. */ @@ -1460,7 +1452,7 @@ rl78_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_addr_bits_remove (gdbarch, rl78_addr_bits_remove); /* Breakpoints. */ - set_gdbarch_breakpoint_from_pc (gdbarch, rl78_breakpoint_from_pc); + SET_GDBARCH_BREAKPOINT_MANIPULATION (rl78); set_gdbarch_decr_pc_after_break (gdbarch, 1); /* Disassembly. */ |