aboutsummaryrefslogtreecommitdiff
path: root/gdb/riscv-tdep.c
diff options
context:
space:
mode:
authorSimon Cook <simon.cook@embecosm.com>2019-05-22 12:59:58 +0100
committerAndrew Burgess <andrew.burgess@embecosm.com>2019-05-22 13:02:51 +0100
commit0a5954bd5f96dd665cb733b9ab6f2ca67bb4632d (patch)
tree33727c7376c4132e4a2623c8fd58f53102d85b96 /gdb/riscv-tdep.c
parent7166f90a7756a3b68cfb93b5ea4a026e9b5f2459 (diff)
downloadgdb-0a5954bd5f96dd665cb733b9ab6f2ca67bb4632d.zip
gdb-0a5954bd5f96dd665cb733b9ab6f2ca67bb4632d.tar.gz
gdb-0a5954bd5f96dd665cb733b9ab6f2ca67bb4632d.tar.bz2
gdb/riscv: Improve flen length determination
This solves an assertion failure when a remote provides a target description which only refers to floating point registers by their hardware name (e.g. f0), rather than their ABI name (e.g. ft0). GDB assumed that should the floating point register feature be presented, it would contain a register called ft0. The floating point length is now instead determined by searching for the same register, but looking for any of its aliases. gdb/ChangeLog: * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from target descriptions using exclusively floating point register name aliases.
Diffstat (limited to 'gdb/riscv-tdep.c')
-rw-r--r--gdb/riscv-tdep.c16
1 files changed, 15 insertions, 1 deletions
diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index 4fe07ef..3fc86ab 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -3094,7 +3094,21 @@ riscv_gdbarch_init (struct gdbarch_info info,
valid_p &= riscv_check_tdesc_feature (tdesc_data, feature_fpu,
&riscv_freg_feature);
- int bitsize = tdesc_register_bitsize (feature_fpu, "ft0");
+ /* Search for the first floating point register (by any alias), to
+ determine the bitsize. */
+ int bitsize = -1;
+ const auto &fp0 = riscv_freg_feature.registers[0];
+
+ for (const char *name : fp0.names)
+ {
+ if (tdesc_unnumbered_register (feature_fpu, name))
+ {
+ bitsize = tdesc_register_bitsize (feature_fpu, name);
+ break;
+ }
+ }
+
+ gdb_assert (bitsize != -1);
features.flen = (bitsize / 8);
if (riscv_debug_gdbarch)