diff options
| author | Tom Tromey <tromey@adacore.com> | 2021-09-17 07:46:03 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2021-09-23 09:30:54 -0600 |
| commit | c80e29dba968beca5eee7210d2030d27fe7790c3 (patch) | |
| tree | b6e08f09ecd225efa78aae2c6966994413a21b5e /gdb/remote.c | |
| parent | 96bbe3ef9653e23a17b2315627e0cab441815f2d (diff) | |
| download | gdb-c80e29dba968beca5eee7210d2030d27fe7790c3.zip gdb-c80e29dba968beca5eee7210d2030d27fe7790c3.tar.gz gdb-c80e29dba968beca5eee7210d2030d27fe7790c3.tar.bz2 | |
Change get_ada_task_ptid parameter type
get_ada_task_ptid currently takes a 'long' as its 'thread' parameter
type. However, on some platforms this is actually a pointer, and
using 'long' can sometimes end up with the value being sign-extended.
This sign extension can cause problems later, if the tid is then later
used as an address again.
This patch changes the parameter type to ULONGEST and updates all the
uses. This approach preserves sign extension on the targets where it
is apparently intended, while avoiding it on others.
Co-Authored-By: John Baldwin <jhb@FreeBSD.org>
Diffstat (limited to 'gdb/remote.c')
| -rw-r--r-- | gdb/remote.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/remote.c b/gdb/remote.c index 3ece443..0dfe36a 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -493,7 +493,7 @@ public: const char *extra_thread_info (struct thread_info *) override; - ptid_t get_ada_task_ptid (long lwp, long thread) override; + ptid_t get_ada_task_ptid (long lwp, ULONGEST thread) override; thread_info *thread_handle_to_thread_info (const gdb_byte *thread_handle, int handle_len, @@ -4136,7 +4136,7 @@ remote_target::static_tracepoint_markers_by_strid (const char *strid) /* Implement the to_get_ada_task_ptid function for the remote targets. */ ptid_t -remote_target::get_ada_task_ptid (long lwp, long thread) +remote_target::get_ada_task_ptid (long lwp, ULONGEST thread) { return ptid_t (inferior_ptid.pid (), lwp); } |