diff options
| author | Pedro Alves <palves@redhat.com> | 2010-02-22 23:35:17 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2010-02-22 23:35:17 +0000 |
| commit | 85d721b88f7efe93142bb8aa8de6f5181830d1dc (patch) | |
| tree | 4b1400e76058dff90370a63a36fe88680ba41d39 /gdb/remote.c | |
| parent | 4c7f0517f37d925f3e1174cef660bef7e102695c (diff) | |
| download | gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.zip gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.tar.gz gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.tar.bz2 | |
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/
* breakpoint.c (insert_bp_location): If inserting the read
watchpoint failed, fallback to an access watchpoint.
(bpstat_check_watchpoint): Stop for read watchpoint triggers even
if the value changed, if not watching the same memory for writes.
(watchpoint_locations_match): Add comment.
(update_global_location_list): Copy the location's watchpoint type.
* i386-nat.c (i386_length_and_rw_bits): It's an internal error to
handle read watchpoints here.
(i386_insert_watchpoint): Read watchpoints aren't supported.
* remote.c (remote_insert_watchpoint): Return 1 for unsupported
packets.
* target.h (target_insert_watchpoint): Update description.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdbserver/
* i386-low.c (i386_length_and_rw_bits): Throw a fatal error if
handing a read watchpoint.
(i386_low_insert_watchpoint): Read watchpoints aren't supported.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/testsuite/
* gdb.base/watch-read.c, gdb.base/watch-read.exp: New files.
Diffstat (limited to 'gdb/remote.c')
| -rw-r--r-- | gdb/remote.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gdb/remote.c b/gdb/remote.c index 6b1a27b..0ed49b9 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7341,7 +7341,7 @@ remote_insert_watchpoint (CORE_ADDR addr, int len, int type) enum Z_packet_type packet = watchpoint_to_Z_packet (type); if (remote_protocol_packets[PACKET_Z0 + packet].support == PACKET_DISABLE) - return -1; + return 1; sprintf (rs->buf, "Z%x,", packet); p = strchr (rs->buf, '\0'); @@ -7355,8 +7355,9 @@ remote_insert_watchpoint (CORE_ADDR addr, int len, int type) switch (packet_ok (rs->buf, &remote_protocol_packets[PACKET_Z0 + packet])) { case PACKET_ERROR: - case PACKET_UNKNOWN: return -1; + case PACKET_UNKNOWN: + return 1; case PACKET_OK: return 0; } |