diff options
author | Michael Snyder <msnyder@vmware.com> | 2011-01-10 20:38:51 +0000 |
---|---|---|
committer | Michael Snyder <msnyder@vmware.com> | 2011-01-10 20:38:51 +0000 |
commit | 0df8b4180acb4890d058c92753dafcd4ff0a87d1 (patch) | |
tree | bd772466e4054c3b326e524993c17e1ac0e974ab /gdb/remote-sim.c | |
parent | a73c6dcdd42994167dfec4db36b0d0ad439d39ad (diff) | |
download | gdb-0df8b4180acb4890d058c92753dafcd4ff0a87d1.zip gdb-0df8b4180acb4890d058c92753dafcd4ff0a87d1.tar.gz gdb-0df8b4180acb4890d058c92753dafcd4ff0a87d1.tar.bz2 |
2011-01-10 Michael Snyder <msnyder@vmware.com>
* nto-procfs.c: Comment cleanup, mostly periods and spaces.
* nto-tdep.c: Ditto.
* nto-tdep.h: Ditto.
* objc-exp.y: Ditto.
* objc-lang.c: Ditto.
* objfiles.c: Ditto.
* objfiles.h: Ditto.
* observer.c: Ditto.
* opencl-lang.c: Ditto.
* osabi.c: Ditto.
* parse.c: Ditto.
* parser-defs.h: Ditto.
* p-exp.y: Ditto.
* p-lang.c: Ditto.
* posix-hdep.c: Ditto.
* ppcbug-rom.c: Ditto.
* ppc-linux-nat.c: Ditto.
* ppc-linux-tdep.c: Ditto.
* ppc-linux-tdep.h: Ditto.
* ppcnbsd-tdep.c: Ditto.
* ppcobsd-tdep.c: Ditto.
* ppcobsd-tdep.h: Ditto.
* ppc-sysv-tdep.c: Ditto.
* ppc-tdep.h: Ditto.
* printcmd.c: Ditto.
* proc-abi.c: Ditto.
* proc-flags.c: Ditto.
* procfs.c: Ditto.
* proc-utils.h: Ditto.
* progspace.h: Ditto.
* prologue-value.c: Ditto.
* prologue-value.h: Ditto.
* psympriv.h: Ditto.
* psymtab.c: Ditto.
* p-typeprint.c: Ditto.
* p-valprint.c: Ditto.
* ravenscar-sparc-thread.c: Ditto.
* ravenscar-thread.c: Ditto.
* ravenscar-thread.h: Ditto.
* record.c: Ditto.
* regcache.c: Ditto.
* regcache.h: Ditto.
* remote.c: Ditto.
* remote-fileio.c: Ditto.
* remote-fileio.h: Ditto.
* remote.h: Ditto.
* remote-m32r-sdi.c: Ditto.
* remote-mips.c: Ditto.
* remote-sim.c: Ditto.
* rs6000-aix-tdep.c: Ditto.
* rs6000-nat.c: Ditto.
* rs6000-tdep.c: Ditto.
Diffstat (limited to 'gdb/remote-sim.c')
-rw-r--r-- | gdb/remote-sim.c | 47 |
1 files changed, 26 insertions, 21 deletions
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c index 1f4e367..f2015f0 100644 --- a/gdb/remote-sim.c +++ b/gdb/remote-sim.c @@ -64,7 +64,7 @@ static void gdb_os_flush_stderr (host_callback *); static int gdb_os_poll_quit (host_callback *); -/* printf_filtered is depreciated */ +/* printf_filtered is depreciated. */ static void gdb_os_printf_filtered (host_callback *, const char *, ...); static void gdb_os_vprintf_filtered (host_callback *, const char *, va_list); @@ -475,7 +475,8 @@ gdbsim_fetch_register (struct target_ops *ops, && nr_bytes != register_size (gdbarch, regno) && warn_user) { fprintf_unfiltered (gdb_stderr, - "Size of register %s (%d/%d) incorrect (%d instead of %d))", + "Size of register %s (%d/%d) " + "incorrect (%d instead of %d))", gdbarch_register_name (gdbarch, regno), regno, gdbarch_register_sim_regno @@ -587,7 +588,7 @@ gdbsim_load (char *args, int fromtty) error (_("unable to load program")); /* FIXME: If a load command should reset the targets registers then - a call to sim_create_inferior() should go here. */ + a call to sim_create_inferior() should go here. */ sim_data->program_loaded = 1; } @@ -644,7 +645,8 @@ gdbsim_create_inferior (struct target_ops *target, char *exec_file, char *args, inferior_appeared (current_inferior (), ptid_get_pid (inferior_ptid)); add_thread_silent (inferior_ptid); - insert_breakpoints (); /* Needed to get correct instruction in cache */ + insert_breakpoints (); /* Needed to get correct instruction + in cache. */ clear_proceed_status (); } @@ -652,7 +654,7 @@ gdbsim_create_inferior (struct target_ops *target, char *exec_file, char *args, /* The open routine takes the rest of the parameters from the command, and (if successful) pushes a new target onto the stack. Targets should supply this routine, if only to provide an error message. */ -/* Called when selecting the simulator. EG: (gdb) target sim name. */ +/* Called when selecting the simulator. E.g. (gdb) target sim name. */ static void gdbsim_open (char *args, int from_tty) @@ -683,7 +685,7 @@ gdbsim_open (char *args, int from_tty) arg_buf = (char *) alloca (len); strcpy (arg_buf, "gdbsim"); /* 7 */ /* Specify the byte order for the target when it is explicitly - specified by the user (not auto detected). */ + specified by the user (not auto detected). */ switch (selected_byte_order ()) { case BFD_ENDIAN_BIG: @@ -725,7 +727,8 @@ gdbsim_open (char *args, int from_tty) /* Allocate the inferior data, but do not allocate a sim instance since we've already just done that. */ - sim_data = get_sim_inferior_data (current_inferior (), SIM_INSTANCE_NOT_NEEDED); + sim_data = get_sim_inferior_data (current_inferior (), + SIM_INSTANCE_NOT_NEEDED); sim_data->gdbsim_desc = gdbsim_desc; @@ -755,7 +758,7 @@ gdbsim_close_inferior (struct inferior *inf, void *arg) set_inferior_data (inf, sim_inferior_data_key, NULL); /* Having a ptid allocated and stored in remote_sim_ptid does - not mean that a corresponding inferior was ever created. + not mean that a corresponding inferior was ever created. Thus we need to verify the existence of an inferior using the pid in question before setting inferior_ptid via switch_to_thread() or mourning the inferior. */ @@ -776,7 +779,7 @@ gdbsim_close_inferior (struct inferior *inf, void *arg) always called just before a routine is popped off the target stack. Closing file descriptors and freeing memory are typical things it should do. */ -/* Close out all files and local state before this target loses control. */ +/* Close out all files and local state before this target loses control. */ static void gdbsim_close (int quitting) @@ -864,7 +867,7 @@ gdbsim_resume (struct target_ops *ops, rd.siggnal = siggnal; rd.step = step; - /* We don't access any sim_data members within this function. + /* We don't access any sim_data members within this function. What's of interest is whether or not the call to get_sim_inferior_data_by_ptid(), above, is able to obtain a non-NULL pointer. If it managed to obtain a non-NULL pointer, we @@ -922,7 +925,8 @@ gdbsim_stop (ptid_t ptid) struct inferior *inf = find_inferior_pid (ptid_get_pid (ptid)); if (inf == NULL) - error (_("Can't stop pid %d. No inferior found."), ptid_get_pid (ptid)); + error (_("Can't stop pid %d. No inferior found."), + ptid_get_pid (ptid)); gdbsim_stop_inferior (inf, NULL); } @@ -951,7 +955,7 @@ gdb_os_poll_quit (host_callback *p) /* Wait for inferior process to do something. Return pid of child, or -1 in case of error; store status through argument pointer STATUS, - just as `wait' would. */ + just as `wait' would. */ static void gdbsim_cntrl_c (int signo) @@ -972,7 +976,8 @@ gdbsim_wait (struct target_ops *ops, When ptid is minus_one_ptid, just use the current inferior. If we're given an explicit pid, we'll try to find it and use that instead. */ if (ptid_equal (ptid, minus_one_ptid)) - sim_data = get_sim_inferior_data (current_inferior (), SIM_INSTANCE_NEEDED); + sim_data = get_sim_inferior_data (current_inferior (), + SIM_INSTANCE_NEEDED); else { sim_data = get_sim_inferior_data_by_ptid (ptid, SIM_INSTANCE_NEEDED); @@ -1031,7 +1036,7 @@ gdbsim_wait (struct target_ops *ops, break; case sim_running: case sim_polling: - /* FIXME: Is this correct? */ + /* FIXME: Is this correct? */ break; } @@ -1047,14 +1052,14 @@ gdbsim_wait (struct target_ops *ops, static void gdbsim_prepare_to_store (struct regcache *regcache) { - /* Do nothing, since we can store individual regs */ + /* Do nothing, since we can store individual regs. */ } /* Transfer LEN bytes between GDB address MYADDR and target address MEMADDR. If WRITE is non-zero, transfer them to the target, otherwise transfer them from the target. TARGET is unused. - Returns the number of bytes transferred. */ + Returns the number of bytes transferred. */ static int gdbsim_xfer_inferior_memory (CORE_ADDR memaddr, gdb_byte *myaddr, int len, @@ -1083,7 +1088,7 @@ gdbsim_xfer_inferior_memory (CORE_ADDR memaddr, gdb_byte *myaddr, int len, if (remote_debug) { - /* FIXME: Send to something other than STDOUT? */ + /* FIXME: Send to something other than STDOUT? */ printf_filtered ("gdbsim_xfer_inferior_memory: myaddr 0x"); gdb_print_host_address (myaddr, gdb_stdout); printf_filtered (", memaddr %s, len %d, write %d\n", @@ -1167,12 +1172,12 @@ simulator_command (char *args, int from_tty) /* PREVIOUSLY: The user may give a command before the simulator is opened. [...] (??? assuming of course one wishes to continue to allow commands to be sent to unopened simulators, - which isn't entirely unreasonable). */ + which isn't entirely unreasonable). */ /* The simulator is a builtin abstraction of a remote target. Consistent with that model, access to the simulator, via sim commands, is restricted to the period when the channel to the - simulator is open. */ + simulator is open. */ error (_("Not connected to the simulator target")); } @@ -1180,7 +1185,7 @@ simulator_command (char *args, int from_tty) sim_do_command (sim_data->gdbsim_desc, args); /* Invalidate the register cache, in case the simulator command does - something funny. */ + something funny. */ registers_changed (); } @@ -1237,7 +1242,7 @@ gdbsim_has_memory (struct target_ops *ops) return 1; } -/* Define the target subroutine names */ +/* Define the target subroutine names. */ struct target_ops gdbsim_ops; |